Skip to content

Commit

Permalink
Compat: skip in-pass-encoder tests if not enough storage textures (#4094
Browse files Browse the repository at this point in the history
)
  • Loading branch information
greggman authored Dec 17, 2024
1 parent 71d7250 commit 64c1fa9
Showing 1 changed file with 12 additions and 1 deletion.
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@ import {
kDepthStencilFormatResolvedAspect,
kTextureFormatInfo,
} from '../../../../format_info.js';
import { MaxLimitsTestMixin } from '../../../../gpu_test.js';
import { ValidationTest } from '../../validation_test.js';

type TextureBindingType =
Expand Down Expand Up @@ -238,7 +239,7 @@ class TextureUsageTracking extends ValidationTest {
}
}

export const g = makeTestGroup(TextureUsageTracking);
export const g = makeTestGroup(MaxLimitsTestMixin(TextureUsageTracking));

const BASE_LEVEL = 1;
const TOTAL_LEVELS = 6;
Expand Down Expand Up @@ -1426,6 +1427,11 @@ g.test('scope,basic,render')
)
)
.fn(t => {
t.skipIf(
t.isCompatibility && !(t.device.limits.maxStorageTexturesInFragmentStage! >= 2),
`maxStorageTexturesInFragmentStage(${t.device.limits.maxStorageTexturesInFragmentStage}) < 2`
);

const { setBindGroup0, setBindGroup1, usage1, usage2 } = t.params;

const { bindGroup0, bindGroup1, encoder, pass } = t.testValidationScope(false, usage1, usage2);
Expand Down Expand Up @@ -1518,6 +1524,11 @@ g.test('scope,pass_boundary,render')
)
)
.fn(t => {
t.skipIf(
t.isCompatibility && !(t.device.limits.maxStorageTexturesInFragmentStage! >= 2),
`maxStorageTexturesInFragmentStage(${t.device.limits.maxStorageTexturesInFragmentStage}) < 2`
);

const { splitPass, draw, usage1, usage2 } = t.params;

const { bindGroupLayouts, bindGroups } = t.makeTwoBindGroupsWithOneTextureView(usage1, usage2);
Expand Down

0 comments on commit 64c1fa9

Please sign in to comment.