address comments

gpuweb · Jan 8, 2025 · 4e590cf · 4e590cf
1 parent 3b92a37
commit 4e590cf
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 2 deletions.
diff --git a/src/webgpu/api/operation/adapter/requestDevice.spec.ts b/src/webgpu/api/operation/adapter/requestDevice.spec.ts
@@ -525,7 +525,8 @@ g.test('always_returns_device')
           !adapterExtensions.isCompatibilityMode &&
             // Current version of Compat design, as of this writing.
             adapterExtensions.featureLevel !== 'compatibility' &&
-            // An unlanded proposed change to the Compat design, but it doesn't hurt to just check.
+            // An as-yet-unlanded proposed change to the Compat design, but for now it doesn't hurt
+            // to just check. Unlanded PR: https://github.com/gpuweb/gpuweb/pull/5036
             !device.features.has('webgpu-core'),
           'must not get a Compatibility adapter if not requested'
         );

diff --git a/src/webgpu/capability_info.ts b/src/webgpu/capability_info.ts
@@ -801,7 +801,8 @@ export function getDefaultLimits(featureLevel: FeatureLevel) {
 }
 
 export function getDefaultLimitsForAdapter(adapter: GPUAdapter) {
-  // MAINTENANCE_TODO: Remove casts when GPUAdapter IDL has isCompatibilityMode.
+  // MAINTENANCE_TODO: Remove casts once we have a standardized way to do this
+  // (see https://github.com/gpuweb/gpuweb/pull/5037#issuecomment-2576110161).
   const adapterExtensions = adapter as unknown as {
     isCompatibilityMode?: boolean;
     featureLevel?: string;