Skip to content

Commit

Permalink
[dawn-node]: Move TSC config to file. (#1382)
Browse files Browse the repository at this point in the history
This PR pulls the typescript config out of the grunt file and adds
the options into the `node.tsconfig.json` file. This also disables
the `incremental` flag in order to work around incorrectly
regenerating the test suite.

The removal of `incremental` takes the Building CTS step to
~14s locally.
  • Loading branch information
dj2 authored May 12, 2022
1 parent 6822b93 commit 11f61c5
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 6 deletions.
4 changes: 0 additions & 4 deletions Gruntfile.js
Original file line number Diff line number Diff line change
Expand Up @@ -62,10 +62,6 @@ module.exports = function (grunt) {
'node_modules/typescript/lib/tsc.js',
'--project', 'node.tsconfig.json',
'--outDir', 'out-node/',
'--incremental', 'true',
'--tsBuildInfoFile', 'out-node/build.tsbuildinfo',
'--noEmit', 'false',
'--declaration', 'false'
],
},
'copy-assets': {
Expand Down
7 changes: 5 additions & 2 deletions node.tsconfig.json
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,10 @@
{
"extends": "./tsconfig.json",
"compilerOptions": {
"module": "commonjs"
"module": "commonjs",
"incremental": false,
"noEmit": false,
"declaration": false,
},

"exclude": [
Expand All @@ -14,4 +17,4 @@
"src/common/runtime/helper/test_worker.ts",
"src/webgpu/web_platform/worker/worker_launcher.ts"
]
}
}

0 comments on commit 11f61c5

Please sign in to comment.