mla problem #28
Open
mla problem #28
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi Mark, the current impl I think is already quite simple, if wanna be faster, reducing the problem shape might be the solution. Do you think its necessary? |
|
No wasn't suggesting we simplify implementation or shape. This is fine and I was just pointing out we could profile and make some simple user facing changes to make the code faster |
|
OK, thats fine |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Forking @danielhua23 PR so I can keep making progress on the branch directly
Tested locally, most of the work was in fixing the test cases, making sure accelerator is used, total runtime is around 4 min which is quite slow and could be optimized a bit more https://github.com/gpu-mode/discord-cluster-manager/actions/runs/14939588938