Skip to content

Feat: enable new modal gpus 🚀 #286

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
S1ro1 wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Feat: enable new modal gpus 🚀 #286

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
059ea0f
Feat: enable new modal gpus 🚀
S1ro1 May 30, 2025
562ff9e
Feat: enable B200
S1ro1 May 31, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions src/discord-cluster-manager/consts.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,7 @@ class ModalGPU(Enum):
A100 = "A100"
H100 = "H100"
B200 = "B200"
H200 = "H200"


@dataclasses.dataclass
Expand Down Expand Up @@ -115,6 +116,7 @@ class RankCriterion(Enum):
"L4": "80",
"A100": "80",
"H100": "90a",
"H200": "90a",
Copy link
Member

@msaroufim msaroufim May 30, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should we enable H200 tho?

Copy link
Member Author

@S1ro1 S1ro1 May 30, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't have a strong opinion, probably not too interesting GPU so idc if we remove.

Copy link
Member

@msaroufim msaroufim May 30, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah'd rather we remove

"B200": "100",
"NVIDIA": None,
"MI300": None,
Expand Down
2 changes: 1 addition & 1 deletion src/discord-cluster-manager/modal_runner_archs.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
from modal_utils import deserialize_full_result
from run_eval import FullResult, SystemInfo

gpus = ["T4", "L4", "A100-80GB", "H100!"]
gpus = ["T4", "L4", "A100-80GB", "H100!", "B200", "H200"]
for gpu in gpus:
gpu_slug = gpu.lower().split("-")[0].strip("!")
app.function(gpu=gpu, image=cuda_image, name=f"run_cuda_script_{gpu_slug}", serialized=True)(
Expand Down
Loading