add StrictQueryParamSep router option (#781)#782
Closed
jub0bs wants to merge 1 commit intogorilla:mainfrom
Closed
Conversation
klauspost
approved these changes
Mar 18, 2025
Contributor
klauspost
left a comment
klauspost
left a comment
There was a problem hiding this comment.
LGTM. Personally I wouldn't mind having it on as default, but I trust your judgement in keeping it off for now.
Author
|
@klauspost Thanks! It would be interesting to hear from other gorilla/mux dependents as well. |
1 task
Author
|
Due to a lack of response from the maintainers, I've decided to close this PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this? (check all applicable)
Description
Add a router option for disabling semicolons as separators for query-parameter pairs (in accordance with the URL Living Standard). Issue #781 discusses two other viable options; please let me know if you prefer one of them and I'll modify this PR accordingly.
Related Tickets & Documents
#781
Added/updated tests?
have not been included
Run verifications and test
make verifyis passingmake testis passing