Skip to content

chore: add forwardRef to all eligible components #2219

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

bryanmylee
Copy link

Motivation

When using styling libraries like Tamagui, it's often useful to wrap components like <BottomSheetView> with the styled function. However, these component wrapper functions require the use of forwardRef on their targets.

When viewing the source, there does not appear to be any reason why forwardRef cannot be used for many components. This PR simply wraps all eligible components and passes the forwardedRef to the inner components.

@bryanmylee
Copy link
Author

Small bump on this, I've been using a patch for this and there have been no issues so far.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant