-
Notifications
You must be signed in to change notification settings - Fork 16
fix: Add currentonly scopes for Apps Script for Docs, Sheets, Slides, and Forms. #47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
🦋 Changeset detectedLatest commit: fbc7865 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Summary of ChangesHello @jpoehnelt, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request enhances the Google Workspace developer tools by integrating Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request adds the currentonly scopes for Apps Script for Docs, Sheets, Slides, and Forms. The implementation is mostly correct, but I've identified a high-severity issue with the scope descriptions. The generic description used for all scopes is misleading to users. I've suggested a refactoring to provide specific and accurate descriptions for each scope, which will improve clarity and user experience.
| export const CURRENT_ONLY_SCOPES = [ | ||
| "https://www.googleapis.com/auth/documents.currentonly", | ||
| "https://www.googleapis.com/auth/forms.currentonly", | ||
| "https://www.googleapis.com/auth/presentations.currentonly", | ||
| "https://www.googleapis.com/auth/spreadsheets.currentonly", | ||
| ]; | ||
|
|
||
| for (const scope of CURRENT_ONLY_SCOPES) { | ||
| SCOPES.set(scope, { | ||
| description: | ||
| "Access the current document, sheet, presentation, or form. The `currentonly` scope is only available within Apps Script Services. This does not include Apps Script Advanced Services or direct calls to Google Workspace APIs.", | ||
| classification: ScopeClassification.NON_SENSITIVE, | ||
| apis: [], | ||
| }); | ||
| } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The current implementation uses a generic description for all currentonly scopes. This can be misleading for users, as it suggests that each scope grants access to documents, sheets, presentations, and forms, rather than just the specific type associated with the scope. For example, the description for https://www.googleapis.com/auth/documents.currentonly should clearly state it only accesses the current document. This improves clarity and ensures users understand the permissions they are granting.
const CURRENT_ONLY_SCOPES_DATA = {
"https://www.googleapis.com/auth/documents.currentonly": "document",
"https://www.googleapis.com/auth/forms.currentonly": "form",
"https://www.googleapis.com/auth/presentations.currentonly": "presentation",
"https://www.googleapis.com/auth/spreadsheets.currentonly": "sheet",
};
export const CURRENT_ONLY_SCOPES = Object.keys(CURRENT_ONLY_SCOPES_DATA);
for (const [scope, entity] of Object.entries(CURRENT_ONLY_SCOPES_DATA)) {
SCOPES.set(scope, {
description:
`Access the current ${entity}. The \`currentonly\` scope is only available within Apps Script Services. This does not include Apps Script Advanced Services or direct calls to Google Workspace APIs.`,
classification: ScopeClassification.NON_SENSITIVE,
apis: [],
});
}
No description provided.