Update SIDECAR_IMAGE tag in Helm chart variable #4051
Conversation
github-actions
bot
added
kind/cleanup
|
Build Failed 😭 Build Id: 3317d7d3-c302-472e-ba46-9eb4ac20bc36 Status: FAILURE To get permission to view the Cloud Build view, join the agones-discuss Google Group. |
|
Build Failed 😭 Build Id: 4d8d868b-1aef-4459-9d91-784b1fe9ef5b Status: FAILURE To get permission to view the Cloud Build view, join the agones-discuss Google Group. |
|
Build Failed 😭 Build Id: ec28f2dd-3fc2-4f54-ac18-dff25cf3cacc Status: FAILURE To get permission to view the Cloud Build view, join the agones-discuss Google Group. |
There was a problem hiding this comment.
I'm not sure this solves the original issue, which seems to be that they want to have different sidecar images for different game server pods. This PR doesn't change that the controller still applies only one SDK image to all game server pods. If we implement the ability for a controller to add different sidecar versions based on something (perhaps label or metadata of a fleet?) this will be a much more involved change.
| @@ -280,6 +280,7 @@ agones: | |||
| pullPolicy: IfNotPresent | |||
| sdk: | |||
| name: agones-sdk | |||
| agonesSdkImage: us-docker.pkg.dev/agones-images/release/agones-sdk:1.46.0-dev | |||
There was a problem hiding this comment.
This image name does not exist. For example, when I create a game server from a development build the game server pod has an image name: image: us-docker.pkg.dev/my-project/my-repo/agones-sdk:1.46.0-dev-cd9b7a1 which is derived from sidecar_tag = $(REGISTRY)/agones-sdk:$(VERSION) in ~/agones/build/Makefile.
|
Closing this as discussed. |
What type of PR is this?
/kind cleanup
What this PR does / Why we need it:
Which issue(s) this PR fixes:
Closes #3979
Special notes for your reviewer: