Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable counter based autoscaler to scale from 0 replicas #4049

Merged

Conversation

geopaulm
Copy link
Contributor

What type of PR is this?

Uncomment only one /kind <> line, press enter to put that in a new line, and remove leading whitespace from that line:

/kind breaking
/kind bug
/kind cleanup
/kind documentation
/kind feature
/kind hotfix
/kind release

What this PR does / Why we need it:
Enables counter based autoscaler to scale up correctly when there are 0 replicas.

Which issue(s) this PR fixes:

Closes #4047

Special notes for your reviewer:

@github-actions github-actions bot added kind/bug These are bugs. size/M labels Nov 25, 2024
@geopaulm
Copy link
Contributor Author

/gcbrun

1 similar comment
@igooch
Copy link
Collaborator

igooch commented Nov 26, 2024

/gcbrun

@agones-bot
Copy link
Collaborator

Build Failed 😭

Build Id: 0a2611c9-157e-4061-b0ca-4bca505784f4

Status: FAILURE

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

@igooch
Copy link
Collaborator

igooch commented Nov 26, 2024

/gcbrun

@agones-bot
Copy link
Collaborator

Build Succeeded 🥳

Build Id: 71889521-823a-47e4-817c-e7f0e18d67aa

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

git fetch https://github.com/googleforgames/agones.git pull/4049/head:pr_4049 && git checkout pr_4049
helm install agones ./install/helm/agones --namespace agones-system --set agones.image.registry=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.46.0-dev-c8d3c61

Copy link
Collaborator

@peterzhongyi peterzhongyi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@peterzhongyi
Copy link
Collaborator

/gcbrun

@peterzhongyi peterzhongyi enabled auto-merge (squash) November 27, 2024 23:17
@peterzhongyi
Copy link
Collaborator

Ran the tests locally, and verified the behaviors by manually incrementing and decrementing the counter on the simple game server to see it scaling up and down.

auto-merge was automatically disabled November 27, 2024 23:36

Head branch was pushed to by a user without write access

@igooch igooch enabled auto-merge (squash) November 28, 2024 00:01
Copy link
Collaborator

@igooch igooch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

@igooch
Copy link
Collaborator

igooch commented Nov 28, 2024

/gcbrun

@agones-bot
Copy link
Collaborator

Build Succeeded 🥳

Build Id: 935d968a-3740-4430-8a54-e2938ebae2f1

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

git fetch https://github.com/googleforgames/agones.git pull/4049/head:pr_4049 && git checkout pr_4049
helm install agones ./install/helm/agones --namespace agones-system --set agones.image.registry=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.46.0-dev-ad9167e

@igooch igooch merged commit cd9b7a1 into googleforgames:main Nov 28, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug These are bugs. size/M
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fleet autoscaler with "Counter" policy throws an error if configured with a fleet with no replicas
4 participants