-
Notifications
You must be signed in to change notification settings - Fork 826
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable counter based autoscaler to scale from 0 replicas #4049
Enable counter based autoscaler to scale from 0 replicas #4049
Conversation
/gcbrun |
1 similar comment
/gcbrun |
Build Failed 😭 Build Id: 0a2611c9-157e-4061-b0ca-4bca505784f4 Status: FAILURE To get permission to view the Cloud Build view, join the agones-discuss Google Group. |
/gcbrun |
Build Succeeded 🥳 Build Id: 71889521-823a-47e4-817c-e7f0e18d67aa The following development artifacts have been built, and will exist for the next 30 days:
A preview of the website (the last 30 builds are retained): To install this version:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
/gcbrun |
Ran the tests locally, and verified the behaviors by manually incrementing and decrementing the counter on the simple game server to see it scaling up and down. |
Head branch was pushed to by a user without write access
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks!
/gcbrun |
Build Succeeded 🥳 Build Id: 935d968a-3740-4430-8a54-e2938ebae2f1 The following development artifacts have been built, and will exist for the next 30 days:
A preview of the website (the last 30 builds are retained): To install this version:
|
What type of PR is this?
What this PR does / Why we need it:
Enables counter based autoscaler to scale up correctly when there are 0 replicas.
Which issue(s) this PR fixes:
Closes #4047
Special notes for your reviewer: