add metadata to agones webhook autoscaler request #3957

swermin · 2024-08-20T06:20:23Z

What type of PR is this?

Uncomment only one /kind <> line, press enter to put that in a new line, and remove leading whitespace from that line:

/kind breaking
/kind bug
/kind cleanup
/kind documentation

/kind feature

/kind hotfix
/kind release

What this PR does / Why we need it:
This PR extends the webhook autoscaler with metadata, so that the the service retrieving the request can use the lables/annotations to do the calculation

Which issue(s) this PR fixes:
Closes #3951

Special notes for your reviewer:

google-cla · 2024-08-20T06:20:27Z

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

agones-bot · 2024-08-20T06:30:13Z

Build Failed 😭

Build Id: 5ade9d2e-d20e-4cad-b76b-697960ab7ff0

Status: FAILURE

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

igooch

Thanks for the contribution. Could you please also add unit and e2e tests?

gongmax · 2024-09-19T17:05:36Z

@swermin kindly ping on this, could you resolve the conflicts and address the above comments?

swermin · 2024-09-20T09:50:09Z

Yes ofc! I have unit tests ready and just left with the e2e tests. I’ll push the current changes and focus on the e2e tests today and this weekend if needed!

agones-bot · 2024-09-22T19:36:24Z

Build Failed 😭

Build Id: 166b3f1b-5297-4b2a-bc9b-3b0ec925abe5

Status: FAILURE

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

agones-bot · 2024-09-22T20:12:56Z

Build Failed 😭

Build Id: 984531ec-7bcc-4fa4-bf36-089d5719a947

Status: FAILURE

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

swermin · 2024-09-24T18:05:02Z

@igooch do you have any good suggestions on how to do the e2e tests for this?
Current default webhook autoscaler is using the example image to test the scaling. I feel like adding support in that image feels a bit weird but I have no good idea on how to add something

agones-bot · 2024-09-24T18:16:49Z

Build Failed 😭

Build Id: 0ef393db-4a59-403f-8729-4a86e54fb6d3

Status: FAILURE

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

igooch · 2024-10-08T19:48:54Z

I just got back from being out of office, so I'm still catching up.

For the e2e tests, do you need to make changes to examples/autoscaler-webhook/main.go? Depending on the test you may be able to simply add MetaData to the default similar to https://github.com/googleforgames/agones/blob/c26f7371980418b56b816b13d265c9cc9d092f32/test/e2e/fleetautoscaler_test.go#L549C14-L549C38. If you do need to make changes to the examples/autoscaler-webhook/main.go, then a maintainer will need to build and push a new example autoscaler webhook image with the changes. That being said, it looks like the unit test is failing.

From the most recent build:

        	Test:       	TestApplyWebhookPolicyWithMetadata
        	            	actual  : 5
        	            	expected: 11
        	Error:      	Not equal: 
        	Error Trace:	/go/src/agones.dev/agones/pkg/fleetautoscalers/fleetautoscalers_test.go:618
    fleetautoscalers_test.go:618: 
--- FAIL: TestApplyWebhookPolicyWithMetadata (0.01s)

You'll need to run ~/agones/build$ make gen-crd-code to generate the deepcopy for pkg/apis/autoscaling/v1/fleetautoscaler.go, but even with that the test is still failing, so there's another issue going on.

agones-bot · 2024-10-21T20:10:12Z

Build Succeeded 🥳

Build Id: 00518f36-9edb-49bc-8c2a-b755dd8f48d1

The following development artifacts have been built, and will exist for the next 30 days:

image: us-docker.pkg.dev/agones-images/ci/agones-controller:1.45.0-dev-9e74cc5
image: us-docker.pkg.dev/agones-images/ci/agones-extensions:1.45.0-dev-9e74cc5
image: us-docker.pkg.dev/agones-images/ci/agones-sdk:1.45.0-dev-9e74cc5-linux
image: us-docker.pkg.dev/agones-images/ci/agones-ping:1.45.0-dev-9e74cc5
image: us-docker.pkg.dev/agones-images/ci/agones-allocator:1.45.0-dev-9e74cc5
Linux C++ SDK (build): agonessdk-1.45.0-dev-9e74cc5-linux-arch_64.tar.gz
SDK Server: agonessdk-server-1.45.0-dev-9e74cc5.zip

A preview of the website (the last 30 builds are retained):

https://9e74cc5-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/googleforgames/agones.git pull/3957/head:pr_3957 && git checkout pr_3957
helm install agones ./install/helm/agones --namespace agones-system --set agones.image.registry=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.45.0-dev-9e74cc5

igooch · 2024-12-13T19:05:12Z

/gcbrun

agones-bot · 2024-12-13T20:11:02Z

Build Succeeded 🥳

Build Id: eb8ecbc4-2d69-463d-befa-65337072b6f2

The following development artifacts have been built, and will exist for the next 30 days:

image: us-docker.pkg.dev/agones-images/ci/agones-controller:1.46.0-dev-2b8baf3
image: us-docker.pkg.dev/agones-images/ci/agones-extensions:1.46.0-dev-2b8baf3
image: us-docker.pkg.dev/agones-images/ci/agones-sdk:1.46.0-dev-2b8baf3-linux
image: us-docker.pkg.dev/agones-images/ci/agones-ping:1.46.0-dev-2b8baf3
image: us-docker.pkg.dev/agones-images/ci/agones-allocator:1.46.0-dev-2b8baf3
Linux C++ SDK (build): agonessdk-1.46.0-dev-2b8baf3-linux-arch_64.tar.gz
SDK Server: agonessdk-server-1.46.0-dev-2b8baf3.zip

A preview of the website (the last 30 builds are retained):

https://2b8baf3-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/googleforgames/agones.git pull/3957/head:pr_3957 && git checkout pr_3957
helm install agones ./install/helm/agones --namespace agones-system --set agones.image.registry=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.46.0-dev-2b8baf3

markmandel · 2025-02-01T19:04:11Z

site/content/en/docs/Reference/fleetautoscaler.md

@@ -374,6 +374,8 @@ type FleetAutoscaleRequest struct {
 	Namespace string `json:"namespace"`
 	// The Fleet's status values
 	Status v1.FleetStatus `json:"status"`
+	// Standard object metadata; More info: https://git.k8s.io/community/contributors/devel/sig-architecture/api-conventions.md#metadata.


Super late to this party, but new additions will need a feature shortcode. See https://agones.dev/site/docs/contribute/#within-a-page for an example.

Also an addition here: https://github.com/googleforgames/agones/blob/main/site/content/en/docs/Guides/feature-stages.md?plain=1#L41 (also feature shortcode - may need to copy the whole table).

This is because docs get published intermediately, so we need to hold back documentation on unreleased features.

markmandel · 2025-02-01T19:05:06Z

Added a note on the issue as well, but my suggestion is that we let this PR through as is (with the above docs changes), and then follow up with e2e test PR.

swermin · 2025-02-03T16:17:37Z

Added a note on the issue as well, but my suggestion is that we let this PR through as is (with the above docs changes), and then follow up with e2e test PR.

Biggest problem with the e2e test is that I need to specify a version of the container to use. So there is no way for me to do the change without having to do two different PRs (at least what I know of)

I tried multiple different ways of getting a e2e test in without having to separate the builds but I cannot seem to find a solution :(

github-actions bot added kind/feature New features for Agones size/S labels Aug 20, 2024

swermin force-pushed the feature/extend-webhook-autoscaler branch from a970b12 to 9ec84ce Compare August 24, 2024 18:32

igooch reviewed Sep 9, 2024

View reviewed changes

swermin force-pushed the feature/extend-webhook-autoscaler branch from 9ec84ce to f56ba00 Compare September 22, 2024 19:28

swermin force-pushed the feature/extend-webhook-autoscaler branch from b9ab8fd to 8d0c86a Compare September 24, 2024 18:05

swermin force-pushed the feature/extend-webhook-autoscaler branch from 8d0c86a to 9e74cc5 Compare October 21, 2024 19:04

markmandel mentioned this pull request Feb 1, 2025

Extend Webhook autoscaler to send fleet metadata with the request #3951

Open

markmandel reviewed Feb 1, 2025

View reviewed changes

swermin force-pushed the feature/extend-webhook-autoscaler branch from 2b4929b to 0c9b515 Compare February 3, 2025 16:18

swermin added 3 commits February 4, 2025 00:44

add metadata to agones webhook autoscaler request

f959dbd

add feature shortcode for the documentation

c87e7a6

add feature to feature stages

315d70d

swermin force-pushed the feature/extend-webhook-autoscaler branch from 0c9b515 to 315d70d Compare February 3, 2025 23:44

swermin requested a review from markmandel February 5, 2025 12:54

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

add metadata to agones webhook autoscaler request #3957

add metadata to agones webhook autoscaler request #3957

swermin commented Aug 20, 2024

google-cla bot commented Aug 20, 2024

agones-bot commented Aug 20, 2024

igooch left a comment

gongmax commented Sep 19, 2024

swermin commented Sep 20, 2024

agones-bot commented Sep 22, 2024

agones-bot commented Sep 22, 2024

swermin commented Sep 24, 2024 •

edited

Loading

agones-bot commented Sep 24, 2024

igooch commented Oct 8, 2024 •

edited

Loading

agones-bot commented Oct 21, 2024

igooch commented Dec 13, 2024

agones-bot commented Dec 13, 2024

markmandel Feb 1, 2025

markmandel commented Feb 1, 2025

swermin commented Feb 3, 2025

add metadata to agones webhook autoscaler request #3957

Are you sure you want to change the base?

add metadata to agones webhook autoscaler request #3957

Conversation

swermin commented Aug 20, 2024

google-cla bot commented Aug 20, 2024

agones-bot commented Aug 20, 2024

igooch left a comment

Choose a reason for hiding this comment

gongmax commented Sep 19, 2024

swermin commented Sep 20, 2024

agones-bot commented Sep 22, 2024

agones-bot commented Sep 22, 2024

swermin commented Sep 24, 2024 • edited Loading

agones-bot commented Sep 24, 2024

igooch commented Oct 8, 2024 • edited Loading

agones-bot commented Oct 21, 2024

igooch commented Dec 13, 2024

agones-bot commented Dec 13, 2024

markmandel Feb 1, 2025

Choose a reason for hiding this comment

markmandel commented Feb 1, 2025

swermin commented Feb 3, 2025

swermin commented Sep 24, 2024 •

edited

Loading

igooch commented Oct 8, 2024 •

edited

Loading