Skip to content

docs(source/snowflake): remove unsupported timeout field from reference #3626

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
anxkhn wants to merge 1 commit into
base: main
Choose a base branch
from
+16 −2
Open

docs(source/snowflake): remove unsupported timeout field from reference #3626

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions docs/en/integrations/snowflake/source.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,5 +58,4 @@ instead of hardcoding your secrets into the configuration file.
| database | string | true | Name of the Snowflake database to connect to (e.g. "my_db"). |
| schema | string | true | Name of the schema to use (e.g. "my_schema"). |
| warehouse | string | false | The virtual warehouse to use. Defaults to "COMPUTE_WH". |
| role | string | false | The security role to use. Defaults to "ACCOUNTADMIN". |
| timeout | integer | false | The connection timeout in seconds. Defaults to 60. |
| role | string | false | The security role to use. Defaults to "ACCOUNTADMIN". |
15 changes: 15 additions & 0 deletions internal/sources/snowflake/snowflake_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -106,6 +106,21 @@ func TestFailParseFromYaml(t *testing.T) {
`,
err: "error unmarshaling source: unable to parse source \"my-snowflake-instance\" as \"snowflake\": Key: 'Config.Schema' Error:Field validation for 'Schema' failed on the 'required' tag",
},
{
desc: "unsupported timeout field",
in: `
kind: source
name: my-snowflake-instance
type: snowflake
account: my-account
user: my_user
password: my_pass
database: my_db
schema: my_schema
timeout: 60
`,
err: "error unmarshaling source: unable to parse source \"my-snowflake-instance\" as \"snowflake\": [6:1] unknown field \"timeout\"\n 3 | name: my-snowflake-instance\n 4 | password: my_pass\n 5 | schema: my_schema\n> 6 | timeout: 60\n ^\n 7 | type: snowflake\n 8 | user: my_user",
},
}
for _, tc := range tcs {
t.Run(tc.desc, func(t *testing.T) {
Expand Down