Skip to content

Conversation

@dishaprakash
Copy link
Contributor

@dishaprakash dishaprakash commented Dec 18, 2025

This is PR no. 5 - Adding support for MCP protocol in core SDK
PR no.4 - #132
PR no.3 - #131
PR no.2 - #128
PR no.1 - #126

Key Changes

  • Protocol Definitions: Added Protocol type and constants
  • Functional Options: Implemented WithProtocol to allow configuring the client version, including validation to prevent duplicate assignment.
  • Factory Logic: Updated NewToolboxClient to instantiate the correct underlying transport (mcp20250618, mcp20250326, mcp20241105, toolbox) based on the configuration.
  • Struct Updates: Added protocol and transport fields to ToolboxClient to store state and configuration.
  • Testing:
    • Added unit tests for WithProtocol (verifying configuration and error handling).
    • Added unit tests for GetSupportedMcpVersions.
    • Added e2e_mcp_test.go to parameterize existing E2E tests across all supported MCP protocol versions using a table-driven approach.

@dishaprakash dishaprakash requested a review from a team as a code owner December 18, 2025 20:08
@twishabansal twishabansal added the priority: p1 Important issue which blocks shipping the next release. Will be fixed prior to next release. label Dec 24, 2025
Base automatically changed from add-mcp-v20250618 to main January 12, 2026 13:25
@dishaprakash dishaprakash merged commit 240c976 into main Jan 12, 2026
6 checks passed
@dishaprakash dishaprakash deleted the integrate-transport branch January 12, 2026 14:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

priority: p1 Important issue which blocks shipping the next release. Will be fixed prior to next release.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants