Skip to content

chore(docs): focus AIP-140 numbers link#1604

Merged
noahdietz merged 1 commit intomainfrom
docs-aip-140-numbers
Feb 17, 2026
Merged

chore(docs): focus AIP-140 numbers link#1604
noahdietz merged 1 commit intomainfrom
docs-aip-140-numbers

Conversation

@noahdietz
Copy link
Contributor

No description provided.

@noahdietz noahdietz requested a review from a team February 17, 2026 19:37
@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @noahdietz, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request refines the documentation by making a specific link more precise. By adding a fragment identifier to the AIP-140 reference, readers will now be directed exactly to the relevant "case" section, improving navigation and clarity within the documentation.

Highlights

  • Documentation Link Update: The link for aip-140 in docs/rules/0140/numbers.md has been updated to include a fragment identifier (#case), directing users to a specific section of the AIP-140 document.
Changelog
  • docs/rules/0140/numbers.md
    • Updated the aip-140 link to point to the specific #case section.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@noahdietz noahdietz enabled auto-merge (squash) February 17, 2026 19:38
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates a link in the documentation for the 0140/numbers rule. The change aims to make the link to AIP-140 more specific. However, the new link points to the #case section, which is about snake_case, while the rule itself is about not using numbers at the beginning of words in field names. I've suggested reverting this change as the original link to the top of the AIP-140 page is more appropriate, given there's no specific anchor for the 'Numbers' section.

top of the file.

[aip-140]: https://aip.dev/140
[aip-140]: https://aip.dev/140#case
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The link to AIP-140 now points to the #case anchor. This rule (0140/numbers) is about not starting words in field names with numbers, which corresponds to the 'Numbers' section of AIP-140. The #case anchor points to the section about using snake_case. Since the 'Numbers' section does not have a specific anchor on the AIP-140 page, linking to the top of the page is more appropriate as it allows users to find the relevant section easily. The previous link was more accurate.

Suggested change
[aip-140]: https://aip.dev/140#case
[aip-140]: https://aip.dev/140

@noahdietz noahdietz merged commit ee5e24b into main Feb 17, 2026
9 checks passed
@noahdietz noahdietz deleted the docs-aip-140-numbers branch February 17, 2026 22:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants