Adds google_mobile_ads support for Swift Package Manager#1395
Adds google_mobile_ads support for Swift Package Manager#1395stuartmorgan-g wants to merge 9 commits intogoogleads:mainfrom
google_mobile_ads support for Swift Package Manager#1395Conversation
| <string>arm64</string> | ||
| </array> | ||
| <key>MinimumOSVersion</key> | ||
| <string>13.0</string> |
There was a problem hiding this comment.
This is an auto-migration from running with a recent version of Flutter; I can revert if you prefer, as it's unrelated, but it will be re-deleted on every run.
There was a problem hiding this comment.
This new file is the result of following the instructions for manually adding SwiftPM support to the example app.
| **/Flutter/flutter_assets/ | ||
| ServiceDefinitions.json | ||
| xcuserdata/ | ||
| xcshareddata/ |
There was a problem hiding this comment.
I'm not sure why this was ignored in the first place, but the scheme details are a necessary part of the project now.
| let package = Package( | ||
| name: "google_mobile_ads", | ||
| platforms: [ | ||
| .iOS("13.0") |
There was a problem hiding this comment.
This is 13.0 rather than the 12.0 used in the podspec because webview-flutter-wkwebview requires 13, and Xcode enforces coherent min versions on a per-target level (unlike CocoaPods, which only fails if the final app has mismatches, which wasn't happening because any app built with a recent version of Flutter requires at least 13.0).
|
The example app still seemed to work and show ads, but since I'm not deeply familiar with the project, someone who is should likely do manual testing as well. |
|
@stuartmorgan-g do the mediation packages also require migration? https://github.com/googleads/googleads-mobile-flutter/tree/main/packages/mediation |
google_mobile_ads support for Swift Package Manager
|
I hadn't looked in there; I didn't realize they were all plugins as well. They will need migration, but it's not as urgent since the breakage reported in the issue is specific to having a dependency on another plugin in the podspec. I've updated my comment in the issue and this PR description to clarify that this only does the one package. |
| <string>arm64</string> | ||
| </array> | ||
| <key>MinimumOSVersion</key> | ||
| <string>13.0</string> |
|
Thanks @stuartmorgan-g! It seems some checks are failing but I feel it's because PR is behind some workflow fixes. Can you rebase so that we can retry the checks? |
Description
Adds Swift Package Manager support to
google_mobile_ads:Related Issues
Fixes #1239
Checklist
Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes (
[x]).This will ensure a smooth and quick review process. Updating the
pubspec.yamland changelogs is not required.///).flutter analyze) does not report any problems on my PR.Breaking Change
Does your PR require plugin users to manually update their apps to accommodate your change?