[macro] Support deriving certain traits via macro #2418
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joshlf
added a commit
to joshlf/cryptocorrosion
that referenced
this pull request
Mar 6, 2025
This commit disables zerocopy's `derive` feature, replacing uses of custom derives with uses of a newly-introducedi [1] `macro_rules!` macro which is specifically added to support the ppv-lite86 and groestl-aesni crates. This allows us to no longer take a dependency on any proc macro derive, and thus to no longer take dependencies on expensive-to-compile crates like syn. [1] google/zerocopy#2418
This was referenced Mar 6, 2025
Derive zerocopy traits via macro, remove custom derive dependency
cryptocorrosion/cryptocorrosion#85
Merged
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2418 +/- ##
==========================================
- Coverage 87.43% 87.21% -0.22%
==========================================
Files 17 17
Lines 6254 6390 +136
==========================================
+ Hits 5468 5573 +105
- Misses 786 817 +31 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
joshlf
force-pushed
the
I6021fbdc0d1e1e30549da129128e5bc002adcee7
branch
2 times, most recently
from
376dbbf to
828752f
Compare
joshlf
force-pushed
the
I6021fbdc0d1e1e30549da129128e5bc002adcee7
branch
2 times, most recently
from
858fbe8 to
a8f814c
Compare
jswrenn
approved these changes
Mar 6, 2025
joshlf
force-pushed
the
I6021fbdc0d1e1e30549da129128e5bc002adcee7
branch
4 times, most recently
from
183db55 to
9dd5e97
Compare
This is intended to specifically support the cryptocorrosion project's ppv-lite86 and groestl-aesni crates. Currently, these crates rely on zerocopy's `derive` feature, which has caused long build times for some dependents such as in [1]. The added macro is `#[doc(hidden)]`, and is only designed to support ppv-lite86 and groestl-aesni. No semver stability guarantees are made except that we will support the use cases of those specific crates. [1] rust-random/rand#1574 (comment) gherrit-pr-id: I6021fbdc0d1e1e30549da129128e5bc002adcee7
joshlf
force-pushed
the
I6021fbdc0d1e1e30549da129128e5bc002adcee7
branch
from
9dd5e97 to
59583e3
Compare
joshlf
added a commit
to joshlf/cryptocorrosion
that referenced
this pull request
Mar 6, 2025
This commit disables zerocopy's `derive` feature, replacing uses of custom derives with uses of a newly-introducedi [1] `macro_rules!` macro which is specifically added to support the ppv-lite86 and groestl-aesni crates. This allows us to no longer take a dependency on any proc macro derive, and thus to no longer take dependencies on expensive-to-compile crates like syn. [1] google/zerocopy#2418
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is intended to specifically support the cryptocorrosion project's
ppv-lite86 and groestl-aesni crates. Currently, these crates rely on
zerocopy's
derivefeature, which has caused long build times for somedependents such as in [1].
The added macro is
#[doc(hidden)], and is only designed to supportppv-lite86 and groestl-aesni. No semver stability guarantees are made
except that we will support the use cases of those specific crates.
[1] rust-random/rand#1574 (comment)
This PR is on branch cryptocorrosion-macro.