Skip to content

exp: Show tables as frequent and look in the columns description #3910

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Dec 1, 2025
Merged

exp: Show tables as frequent and look in the columns description #3910

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
fbcabb7
exp: Show tables as frequent and look in the columns description
aMayzner Nov 28, 2025
f6956e0
better ordering
aMayzner Nov 29, 2025
b8c5194
md support
aMayzner Nov 29, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions python/generators/sql_processing/stdlib_tags.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -451,8 +451,8 @@ def _validate_tags():
# Table importance levels for documentation.
# Importance levels help users discover the most relevant tables for their use case.
# Levels:
# 'high': Most commonly used, fundamental tables for trace analysis
# 'mid': Important for specific use cases, moderately common
# 'high': Very frequent - Most commonly used, fundamental tables for trace analysis
# 'mid': Frequent - Important for specific use cases, moderately common
# 'low': Specialized or advanced tables, less frequently needed
# None/absent: Normal importance (default)
TABLE_IMPORTANCE = {
Expand Down Expand Up @@ -481,6 +481,7 @@ def _validate_tags():
'android_anrs': 'mid', # Application Not Responding events and diagnostics
'android_battery_charge': 'mid', # Battery charge level tracking over time
'android_charging_states': 'mid', # Device charging state transitions
'android_process_metadata': 'mid', # Process metadata and information

# LOW IMPORTANCE - Raw/specialized tables, less frequently needed
'slices':
Expand Down
4 changes: 2 additions & 2 deletions ui/src/plugins/dev.perfetto.ExplorePage/query_builder/help.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -80,11 +80,11 @@
}

.pf-importance-high {
background-color: #d32f2f; // Red - Important
background-color: #d32f2f; // Red - Very frequent
}

.pf-importance-mid {
background-color: var(--pf-color-primary); // Primary blue - Recommended
background-color: var(--pf-color-primary); // Primary blue - Frequent
}

.pf-importance-low {
Expand Down
75 changes: 75 additions & 0 deletions ui/src/plugins/dev.perfetto.ExplorePage/query_builder/table_list.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,3 +38,78 @@
}
}
}

.pf-table-card-header {
.pf-match-type-chip {
background-color: var(--surface-variant);
color: var(--on-surface-variant);
font-size: 11px;
opacity: 0.8;
}
}

.table-description {
// Inline code styling
code {
background-color: var(--surface-variant);
padding: 2px 6px;
border-radius: 3px;
font-family: "Roboto Mono", monospace;
font-size: 0.9em;
color: var(--on-surface);
}

// Links
a {
color: var(--primary);
text-decoration: none;

&:hover {
text-decoration: underline;
}
}

// Bold text
strong {
font-weight: 500;
}

// Italic text
em {
font-style: italic;
}

// Paragraphs
p {
margin: 0.5em 0;

&:first-child {
margin-top: 0;
}

&:last-child {
margin-bottom: 0;
}
}

// Lists
ul,
ol {
margin: 0.5em 0;
padding-left: 1.5em;
}

// Code blocks
pre {
background-color: var(--surface-variant);
padding: 8px 12px;
border-radius: 4px;
overflow-x: auto;
margin: 0.5em 0;

code {
background-color: transparent;
padding: 0;
}
}
}
Loading