Skip to content

ui: support searching int args #3853

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
+13 −2
Open

ui: support searching int args #3853

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions ui/src/core/search_manager.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -246,8 +246,11 @@ export class SearchManagerImpl implements SearchManager {
track_id as sourceId,
0 as utid
from slice
join args using(arg_set_id)
where string_value glob ${searchLiteral} or key glob ${searchLiteral}
join (
select arg_set_id from args where display_value glob ${searchLiteral}
union
select arg_set_id from args where key glob ${searchLiteral}
) using(arg_set_id)
)
union all
select
Expand Down
8 changes: 8 additions & 0 deletions ui/src/test/chrome_rendering_desktop.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,3 +45,11 @@ test('slice with flows', async () => {
await pth.waitForPerfettoIdle();
await pth.waitForIdleAndScreenshot('slice_with_flows.png');
});

test('search int arg', async () => {
await pth.searchSlice('5292083664613144124');
await pth.resetFocus();
await page.keyboard.press('f');
await pth.waitForPerfettoIdle();
await pth.waitForIdleAndScreenshot('search_int_arg.png');
});
Loading