Repository navigation
ui: Refactor Wattson warning logic and improve config checks - #3840
Merged
Merged
Conversation
This commit is the improvement of #3012, which was reverted because of following reasons: ``` Reason: Two-fold: 1) Wattson is not enough of a "core Perfetto feature" that we need to have the tracks show up on every trace type. For example, right now, this will show up on Linux traces, heap profiles heap dumps etc. Unconditionally showing tracks when you have no data is not OK: the user may have very intentially not enabled your stuff, warning them every time and using valuable real estate is unacceptable. If we want something like this, we should add something to a section on the info and stats page but even then, we need to scope it to "if the person expected Wattson to be enabled": if they don't care about it, it should not bother them 2) Tried on a random trace and the warnings just appeared broken. If clicked on the warning, nothing showed up. ``` Improvement to above suggestions: 1) It makes sense that showing Wattson unconditionally is not ok. Not everyone is using Perfetto for Wattson. Therefore this change will only make Wattson warnings and blank tracks visible to "Wattson users" who have enabled Wattson Markers. Enabling the marker is the sign of user's intention of using Wattson. If a user didn't enable the marker, no wattson track or warning will be bother the user. 2) Tested ok. Right now this code change is only applicable to power/cpu_frequency and devfreq/devfreq_frequency. Test: Local Perfetto UI Test Bug: 444535474
🎨 Perfetto UI Build✅ UI build is ready: https://storage.googleapis.com/perfetto-ci-artifacts/gh-19654499662-ui/ui/index.html |
runpinglai-creator
requested review from
LalitMaganti and
wusamuel6
and removed request for
LalitMaganti
November 25, 2025 18:41
wusamuel6
approved these changes
Nov 26, 2025
LalitMaganti
approved these changes
Nov 27, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit is the improvement of
#3012, which was reverted because of following reasons:
Improvement to above suggestions:
ok. Not everyone is using Perfetto for Wattson. Therefore this change
will only make Wattson warnings and blank tracks visible to "Wattson
users" who have enabled Wattson Markers. Enabling the marker is the
sign of user's intention of using Wattson. If a user didn't enable the
marker, no wattson track or warning will be bother the user.
power/cpu_frequency(checking both atrace, ftrace, and cpu_freq_ms)and
devfreq/devfreq_frequency.Test: Local Perfetto UI Test
Bug: 444535474
Welcome to Perfetto!
Make sure your PR has a bug/issue attached or has at least
a clear description of the problem you are trying to fix.
For more details please see
https://perfetto.dev/docs/contributing/getting-started