Replace text-weight: bolder with 500 to improve text clarity
#3668
+6
−6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Change-Id: I6d38b934cc79ca0655bd1f5637564601d635bee1
stevegolton
changed the title
text-weight: bolder with 500 as this is much cleanertext-weight: bolder with 500 to improve text clarity
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently we use
font-weight: bolderin a few places to make some text bolder relative to the parent. This is fine but the actual implementation of bolder is uses banding to determine which level is chosen. See: https://developer.mozilla.org/en-US/docs/Web/CSS/Reference/Properties/font-weight#meaning_of_relative_weights. In short, the only outputs of bolder are 400, 700, and 900.Since we only have a handful of Roboto weights available, the boldest of which being 500, it makes sense to just hard code these fonts to weight 500 instead of using bolder.