feat(maven): only fetch snapshots and releases when enabled #1436
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1436 +/- ##
==========================================
- Coverage 67.25% 67.21% -0.04%
==========================================
Files 192 192
Lines 18133 18169 +36
==========================================
+ Hits 12196 12213 +17
- Misses 5291 5310 +19
Partials 646 646 ☔ View full report in Codecov by Sentry. |
oliverchang
approved these changes
Dec 18, 2024
michaelkedar
approved these changes
Dec 19, 2024
cuixq
added a commit
to cuixq/osv-scanner
that referenced
this pull request
Dec 19, 2024
) google#1280 In Maven pom.xml, download policies can be specified for repositories to decide whether to fetch releases/snapshots or not, which is currently not supported in MavenRegistryAPIClient. This causes us making many unnecessary requests. This PR defines a new data structure to hold information for a Maven registry including the download policies. For the default registry, we assume it is only allowed to download releases (it can be a TODO to support specifying this via CLI flags).
cuixq
added a commit
that referenced
this pull request
Dec 19, 2024
This PR cherry-pick two fixes to v1: - #1436 - #1456 --------- Co-authored-by: Michael Kedar <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#1280
In Maven pom.xml, download policies can be specified for repositories to decide whether to fetch releases/snapshots or not, which is currently not supported in MavenRegistryAPIClient. This causes us making many unnecessary requests.
This PR defines a new data structure to hold information for a Maven registry including the download policies. For the default registry, we assume it is only allowed to download releases (it can be a TODO to support specifying this via CLI flags).