-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
pyjwt: improves code coverage #9832
base: master
Are you sure you want to change the base?
Conversation
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
c3e60a2
to
38570d6
Compare
@DavidKorczynski do you approve? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think in general when we go for making changes in existing fuzzers we should try to make it so existing seeds do not exhibit different behaviour. This PR and e.g #9967 does that -- could you perhaps address this (just in this PR not the ones that's merged) @jesslatimer ?
projects/pyjwt/fuzz_jwt.py
Outdated
"""Check payload == decoded(encoded(payload)) using RS256""" | ||
try: | ||
payload = json.loads(data) | ||
keyfile = json.loads(data) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's make payload
and keyfile
different (i.e different bytes for json.loads
).
Not a problem at all, but could you please clarify what you would like changed @DavidKorczynski? Is the |
The main point is to ensure a state where if the The change in this fuzzer modification that causes this friction is that given the same |
This change adds; - a fuzz corpus - fuzzing for jwk - each function consumes own data Signed-off-by: Jessica Latimer <[email protected]>
This change adds;