Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proposing that maldoca be added to oss-fuzz. #5935

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

oanise93
Copy link

@oanise93 oanise93 commented Jun 17, 2021

Following the process to add a new library to OSS-Fuzz. MalDocA is a new open-source project released by Google.

@DavidKorczynski
Copy link
Collaborator

Thanks @oanise93 - Do you have any fuzzers written for MalDocA as well?

@oanise93
Copy link
Author

Thanks for the quick response @DavidKorczynski! We haven't written any fuzzing targets yet but wanted to go ahead and submit the library for approval. Is approval conditional on having those fuzzing targets created?

@DavidKorczynski
Copy link
Collaborator

DavidKorczynski commented Jun 17, 2021

Ah fair, yes you should be able to get approval before submitting a fuzzer, but no analysis will happen if no fuzzers are written for the project.

I think this should be good to get in since it's a Google project, but will defer the decision to one of @inferno-chromium @jonathanmetzman @asraa @oliverchang

@oanise93
Copy link
Author

Totally understand, thanks for that clarification.

@jonathanmetzman
Copy link
Contributor

Ah fair, yes you should be able to get approval before submitting a fuzzer, but no analysis will happen if no fuzzers are written for the project.

I think this should be good to get in since it's a Google project, but will defer the decision to one of @inferno-chromium @jonathanmetzman @asraa @oliverchang

We approve.

@oanise93
Copy link
Author

@DavidKorczynski I plan to start working on adding the fuzzing targets today but wanted to check if I will need to land this version of the PR first or if I should make the changes to add the build file, Dockerfile, etc in this same PR?

@DavidKorczynski
Copy link
Collaborator

@DavidKorczynski I plan to start working on adding the fuzzing targets today but wanted to check if I will need to land this version of the PR first or if I should make the changes to add the build file, Dockerfile, etc in this same PR?

We can keep this PR open and then you can push the Dockerfile and build.sh to this PR, as usually we have all the three artifacts when doing an initial integration. Jonathan approved the project so I can assist here in getting the set up correct and then merge in when it is ready.

@google-cla
Copy link

google-cla bot commented Jun 23, 2021

All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter.

We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only @googlebot I consent. in this pull request.

Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the cla label to yes (if enabled on your project).

ℹ️ Googlers: Go here for more info.

@google-cla
Copy link

google-cla bot commented Jun 24, 2021

All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter.

We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only @googlebot I consent. in this pull request.

Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the cla label to yes (if enabled on your project).

ℹ️ Googlers: Go here for more info.

@DavidKorczynski
Copy link
Collaborator

The CI is currently failing in the building of the fuzzers. Did you verify the following commands work?

python infra/helper.py build_fuzzers maldoca
python infra/helper.py check_build maldoca

@oanise93
Copy link
Author

@DavidKorczynski apologies for the noise. I was pushing to the branch so that a colleague could help me debug an issue I am running into with python infra/helper.py build_fuzzers maldoca

@DavidKorczynski
Copy link
Collaborator

Ah no problem - I was essentially offering my assistance if you needed it!

@inferno-chromium
Copy link
Collaborator

ping!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants