-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Proposing that maldoca be added to oss-fuzz. #5935
base: master
Are you sure you want to change the base?
Conversation
Thanks @oanise93 - Do you have any fuzzers written for MalDocA as well? |
Thanks for the quick response @DavidKorczynski! We haven't written any fuzzing targets yet but wanted to go ahead and submit the library for approval. Is approval conditional on having those fuzzing targets created? |
Ah fair, yes you should be able to get approval before submitting a fuzzer, but no analysis will happen if no fuzzers are written for the project. I think this should be good to get in since it's a Google project, but will defer the decision to one of @inferno-chromium @jonathanmetzman @asraa @oliverchang |
Totally understand, thanks for that clarification. |
We approve. |
@DavidKorczynski I plan to start working on adding the fuzzing targets today but wanted to check if I will need to land this version of the PR first or if I should make the changes to add the build file, Dockerfile, etc in this same PR? |
We can keep this PR open and then you can push the |
All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the ℹ️ Googlers: Go here for more info. |
All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the ℹ️ Googlers: Go here for more info. |
The CI is currently failing in the building of the fuzzers. Did you verify the following commands work?
|
@DavidKorczynski apologies for the noise. I was pushing to the branch so that a colleague could help me debug an issue I am running into with |
Ah no problem - I was essentially offering my assistance if you needed it! |
ping! |
Following the process to add a new library to OSS-Fuzz. MalDocA is a new open-source project released by Google.