Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[infra] Dont upload a build status for all projects #5609

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

jonathanmetzman
Copy link
Contributor

Projects that are deleted/disabled/incomplete should not get them.

Fixes #5608

Projects that are deleted/disabled/incomplete should not get them.

Fixes #5608
Copy link
Contributor

@asraa asraa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Code looks great, could I ask a quick question I was wondering when looking at the code?

Eventually history will be None for projects when we process them and we'll just skip them, so this fixes when there's some historical builds but now the project is deleted/incomplete/etc? I like your solution more than removing history if not project_should_build.

@jonathanmetzman
Copy link
Contributor Author

Thanks! Code looks great, could I ask a quick question I was wondering when looking at the code?

Eventually history will be None for projects when we process them and we'll just skip them, so this fixes when there's some historical builds but now the project is deleted/incomplete/etc? I like your solution more than removing history if not project_should_build.

Exactly.

@@ -39,6 +41,9 @@

FUZZING_STATUS_FILENAME = 'status.json'
COVERAGE_STATUS_FILENAME = 'status-coverage.json'
PROJECTS_DIR = os.path.normpath(
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This won't work unfortunately, because this is not run as part of an OSS-Fuzz checkout.

Instead, what we can do to fix this here is to do a datastore query for the Project entity:

Project(name=project_name,

If it does not exist, then don't upload.

These entities are already being deleted when a project is deleted, but not when it's disabled:

delete_project(cloud_scheduler_client, project)

Probably need to change something around here to check for the disabled attribute:

def get_projects(repo):

Copy link
Collaborator

@inferno-chromium inferno-chromium left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

request changes as per last review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error being thrown because no coverage/fuzzing build done for many disabled/deleted projects.
4 participants