Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

vlc: use official repo + add seeds and dicts + add demuxers #13010

Merged
merged 5 commits into from
Feb 10, 2025
Merged

vlc: use official repo + add seeds and dicts + add demuxers #13010

merged 5 commits into from
Feb 10, 2025

Conversation

tguillem
Copy link
Contributor

@tguillem tguillem commented Feb 6, 2025 •
edited
Loading

  • Remove useless vlc-demux-libfuzzer output target
  • Use the official VideoLAN/vlc repository
  • Add seeds and dicts: create one output target per format
  • Add mkv, ogg, xml support

@google-cla Google CLA
Copy link

google-cla bot commented Feb 6, 2025

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 6, 2025

tguillem is a new contributor to projects/vlc. The PR must be approved by known contributors before it can be merged. The past contributors are: tmatth

@tguillem tguillem force-pushed the vlc-improve-fuzzing branch 2 times, most recently from bd905c4 to 0a5b038 Compare February 6, 2025 10:53
@tguillem tguillem force-pushed the vlc-improve-fuzzing branch 2 times, most recently from a923b2b to 6dba343 Compare February 6, 2025 15:34
@tguillem tguillem changed the title vlc: use official repo + add seeds and dicts vlc: use official repo + add seeds and dicts + add demuxers Feb 6, 2025
@tguillem tguillem force-pushed the vlc-improve-fuzzing branch from 6dba343 to 05d53d1 Compare February 8, 2025 05:56
@tguillem
vlc: remove vlc-demux-libfuzzer
5eec3e0 
vlc-demux-dec-libfuzzer is demuxing + trying to decode streams.
vlc-demux-libfuzzer is only demuxing.

So, no need to run them both.
@tguillem
vlc: use main VideoLAN repository
7e14a2f 
And not the mirrored one.
@tguillem
vlc: use seeds and dicts from a VideoLAN repository
73fa41e 
And create one target per demux format.

Here is the output folder after this commit:

```
vlc-demux-dec-libfuzzer
vlc-demux-dec-asf-libfuzzer
vlc-demux-dec-asf-libfuzzer_seed_corpus.zip
vlc-demux-dec-avi-libfuzzer
vlc-demux-dec-avi-libfuzzer.dict
vlc-demux-dec-avi-libfuzzer_seed_corpus.zip
vlc-demux-dec-dirac-libfuzzer
vlc-demux-dec-dirac-libfuzzer_seed_corpus.zip
vlc-demux-dec-dts-libfuzzer
vlc-demux-dec-dts-libfuzzer_seed_corpus.zip
vlc-demux-dec-flac-libfuzzer
vlc-demux-dec-flac-libfuzzer_seed_corpus.zip
vlc-demux-dec-h264-libfuzzer
vlc-demux-dec-h264-libfuzzer_seed_corpus.zip
vlc-demux-dec-h265-libfuzzer
vlc-demux-dec-h265-libfuzzer_seed_corpus.zip
vlc-demux-dec-image-libfuzzer
vlc-demux-dec-image-libfuzzer.dict
vlc-demux-dec-image-libfuzzer_seed_corpus.zip
vlc-demux-dec-midi-libfuzzer
vlc-demux-dec-midi-libfuzzer_seed_corpus.zip
vlc-demux-dec-mkv-libfuzzer
vlc-demux-dec-mkv-libfuzzer_seed_corpus.zip
vlc-demux-dec-mp3-libfuzzer
vlc-demux-dec-mp3-libfuzzer_seed_corpus.zip
vlc-demux-dec-mp4-libfuzzer
vlc-demux-dec-mp4-libfuzzer.dict
vlc-demux-dec-mp4-libfuzzer_seed_corpus.zip
vlc-demux-dec-mpc-libfuzzer
vlc-demux-dec-mpc-libfuzzer_seed_corpus.zip
vlc-demux-dec-ogg-libfuzzer
vlc-demux-dec-ogg-libfuzzer_seed_corpus.zip
vlc-demux-dec-pva-libfuzzer
vlc-demux-dec-pva-libfuzzer_seed_corpus.zip
vlc-demux-dec-sdp-libfuzzer
vlc-demux-dec-sdp-libfuzzer_seed_corpus.zip
vlc-demux-dec-stl-libfuzzer
vlc-demux-dec-stl-libfuzzer_seed_corpus.zip
vlc-demux-dec-subtitle-libfuzzer
vlc-demux-dec-subtitle-libfuzzer.dict
vlc-demux-dec-subtitle-libfuzzer_seed_corpus.zip
vlc-demux-dec-ts-libfuzzer
vlc-demux-dec-ts-libfuzzer_seed_corpus.zip
vlc-demux-dec-ty-libfuzzer
vlc-demux-dec-ty-libfuzzer_seed_corpus.zip
vlc-demux-dec-ttml-libfuzzer
vlc-demux-dec-ttml-libfuzzer.dict
vlc-demux-dec-ttml-libfuzzer_seed_corpus.zip
vlc-demux-dec-vob-libfuzzer
vlc-demux-dec-vob-libfuzzer_seed_corpus.zip
vlc-demux-dec-voc-libfuzzer
vlc-demux-dec-voc-libfuzzer_seed_corpus.zip
vlc-demux-dec-wav-libfuzzer
vlc-demux-dec-wav-libfuzzer_seed_corpus.zip
vlc-demux-dec-webvtt-libfuzzer
vlc-demux-dec-webvtt-libfuzzer.dict
vlc-demux-dec-webvtt-libfuzzer_seed_corpus.zip
vlc-demux-dec-xa-libfuzzer
vlc-demux-dec-xa-libfuzzer_seed_corpus.zip
```
@tguillem
vlc: enable mkv,ogg and xml plugins
ddbb3d4
@tguillem
vlc: disable nls
92893ec 
No need to fuzz translations and it takes some time to generate.
@tguillem tguillem force-pushed the vlc-improve-fuzzing branch from 05d53d1 to 92893ec Compare February 8, 2025 06:56
@DavidKorczynski DavidKorczynski merged commit f62a81f into google:master Feb 10, 2025
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tmatth tmatth tmatth approved these changes

@DavidKorczynski DavidKorczynski DavidKorczynski approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tguillem @tmatth @DavidKorczynski