Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

infra: update introspector and add new light version #12983

Merged
merged 4 commits into from
Jan 28, 2025

Conversation

DavidKorczynski
Copy link
Collaborator

Adds a light version of FI that should work on all projects. This will only be used if the existing FI does not work, e.g. due to failures around LTO.

Also starts using the CLI version of fuzz-introspector as opposed to calling main.py.

Adds a light version of FI that should work on all projects. This will
only be used if the existing FI does not work, e.g. due to failures
around LTO.

Signed-off-by: David Korczynski <[email protected]>
@DavidKorczynski
Copy link
Collaborator Author

/gcbrun trial_build.py all --sanitizer introspector --fuzzing-engine libfuzzer

Signed-off-by: David Korczynski <[email protected]>
@DavidKorczynski
Copy link
Collaborator Author

/gcbrun trial_build.py all --sanitizer introspector --fuzzing-engine libfuzzer

@evverx
Copy link
Contributor

evverx commented Jan 26, 2025

a light version of FI that should work on all projects

I saw #12959 the other day and I wonder what it's going to look like in the context of that issue? Is it going to be possible to see that the full FI isn't supported? (It's probably a UI issue unrelated to this PR though).

FWIW it's possible to build systemd FI reports by tweaking the systemd build script/system downstream (the hardest part is to link all that stuff statically). It's just not supported upstream.

@DavidKorczynski
Copy link
Collaborator Author

a light version of FI that should work on all projects

I saw #12959 the other day and I wonder what it's going to look like in the context of that issue? Is it going to be possible to see that the full FI isn't supported? (It's probably a UI issue unrelated to this PR though).

FWIW it's possible to build systemd FI reports by tweaking the systemd build script/system downstream (the hardest part is to link all that stuff statically). It's just not supported upstream.

Yeah, I'll add it to the UI so it's possible to see what approach is used.

I appreciate the systemd part -- though, having a pure static approach (i.e. not depending on build or runtime artifacts) comes with other benefits and enables other uses, so adding this to FI is not only a response to e.g. attributes of meson or similar as such.

@evverx
Copy link
Contributor

evverx commented Jan 26, 2025

having a pure static approach (i.e. not depending on build or runtime artifacts) comes with other benefits and enables other uses

Agreed. I think what I was trying to say is that the UI should make it clear where things come from (and how well supported they are). I added exit 1 and the comment clarifying the full FI situation upstream to somewhat make it clear that it doesn't work (at the time incomplete reports were built and shown and it was somewhat confusing for external contributors. These days there are no links to full FI reports so it's not an issue anymore apart from the build status apparently). Then again it's a UI thing probably.

@DavidKorczynski
Copy link
Collaborator Author

DavidKorczynski commented Jan 26, 2025

Got it, good point and thanks @evverx -- will make sure to adjust the UI to make the status of the report clear

Signed-off-by: David Korczynski <[email protected]>
@DavidKorczynski
Copy link
Collaborator Author

/gcbrun trial_build.py all --sanitizer introspector --fuzzing-engine libfuzzer

@DavidKorczynski
Copy link
Collaborator Author

/gcbrun trial_build.py all --sanitizer introspector --fuzzing-engine libfuzzer

@DavidKorczynski
Copy link
Collaborator Author

Failing projects have been resolved, this is good to go now

@DavidKorczynski DavidKorczynski merged commit 375486d into master Jan 28, 2025
18 of 19 checks passed
@DavidKorczynski DavidKorczynski deleted the update-infra branch January 28, 2025 10:25
thomasvl pushed a commit to thomasvl/oss-fuzz that referenced this pull request Jan 29, 2025
Adds a light version of FI that should work on all projects. This will
only be used if the existing FI does not work, e.g. due to failures
around LTO.

Also starts using the CLI version of fuzz-introspector as opposed to
calling `main.py`.

---------

Signed-off-by: David Korczynski <[email protected]>
@evverx
Copy link
Contributor

evverx commented Jan 31, 2025

Looking at https://introspector.oss-fuzz.com/project-profile?project=systemd it now says that FI builds fail as expected so it seems #12959 can probably be closed.

Edit: I took a closer look at https://oss-fuzz-build-logs.storage.googleapis.com/log-b1b11209-06cb-4ba9-beff-fea56b67cf0f.txt and it seems it times out so it's probably unrelated to #12959 after all.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants