-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
infra: update introspector and add new light version #12983
Conversation
Adds a light version of FI that should work on all projects. This will only be used if the existing FI does not work, e.g. due to failures around LTO. Signed-off-by: David Korczynski <[email protected]>
/gcbrun trial_build.py all --sanitizer introspector --fuzzing-engine libfuzzer |
Signed-off-by: David Korczynski <[email protected]>
/gcbrun trial_build.py all --sanitizer introspector --fuzzing-engine libfuzzer |
I saw #12959 the other day and I wonder what it's going to look like in the context of that issue? Is it going to be possible to see that the full FI isn't supported? (It's probably a UI issue unrelated to this PR though). FWIW it's possible to build systemd FI reports by tweaking the systemd build script/system downstream (the hardest part is to link all that stuff statically). It's just not supported upstream. |
Yeah, I'll add it to the UI so it's possible to see what approach is used. I appreciate the systemd part -- though, having a pure static approach (i.e. not depending on build or runtime artifacts) comes with other benefits and enables other uses, so adding this to FI is not only a response to e.g. attributes of meson or similar as such. |
Agreed. I think what I was trying to say is that the UI should make it clear where things come from (and how well supported they are). I added |
Got it, good point and thanks @evverx -- will make sure to adjust the UI to make the status of the report clear |
Signed-off-by: David Korczynski <[email protected]>
/gcbrun trial_build.py all --sanitizer introspector --fuzzing-engine libfuzzer |
/gcbrun trial_build.py all --sanitizer introspector --fuzzing-engine libfuzzer |
Failing projects have been resolved, this is good to go now |
Adds a light version of FI that should work on all projects. This will only be used if the existing FI does not work, e.g. due to failures around LTO. Also starts using the CLI version of fuzz-introspector as opposed to calling `main.py`. --------- Signed-off-by: David Korczynski <[email protected]>
Looking at https://introspector.oss-fuzz.com/project-profile?project=systemd it now says that FI builds fail as expected so it seems #12959 can probably be closed. Edit: I took a closer look at https://oss-fuzz-build-logs.storage.googleapis.com/log-b1b11209-06cb-4ba9-beff-fea56b67cf0f.txt and it seems it times out so it's probably unrelated to #12959 after all. |
Adds a light version of FI that should work on all projects. This will only be used if the existing FI does not work, e.g. due to failures around LTO.
Also starts using the CLI version of fuzz-introspector as opposed to calling
main.py
.