-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pdfplumber: Integration #12949
Pdfplumber: Integration #12949
Conversation
ennamarie19 has previously contributed to projects/pdfplumber. The previous PR was #12567 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, @ennamarie19
Thank you, @ennamarie19. I'm the maintainer of Is there a way to set up the fuzzer to ignore errors that originate with that dependency? That would help me focus on issues I can directly fix in |
Typically, we could add an exception handler in the fuzz harness for certain exceptions that are raised that we aren’t interested in. Ideally, it would be the base class of a library’s custom exception (ie, PSException).
However, in this case, that is a genuine bug in a library that you depend on.
I see two main options: We could ignore them using a catch that parses the exception trace back and filter for pdfminer or add try catches in the code when calling into pdfminer to handle exceptions from sub calls more robustly and prevent pdfplumber crashing unexpectedly. Which do you prefer?On Jan 29, 2025, at 9:11 PM, Jeremy Singer-Vine ***@***.***> wrote:
Thank you, @ennamarie19. I'm the maintainer of pdfplumber. I've started receiving results of the fuzzing via email. Some look helpful, while others appeared to be triggered by problems with a core dependency, pdfminer.six. For example, this one: https://oss-fuzz.com/testcase-detail/5914823472250880
Is there a way to set up the fuzzer to ignore errors that originate with that dependency? That would help me focus on issues I can directly fix in pdfplumber.
—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you were mentioned.Message ID: ***@***.***>
|
... thanks to OSS-Fuzz and @ennamarie19 Cf.: google/oss-fuzz#12949
Thanks, @ennamarie19. I've pushed a commit that handles exceptions stemming from Would it make sense to have the fuzzer then ignore these particular exceptions?: from pdfplumber.utils.exceptions import MalformedPDFException, PdfminerException |
This pull request integrates the Dockerfile needed to build the fuzzers for pdfplumber.
Note: The fuzzers were NOT merged upstream following discussion with the project maintainer here and with the precedence for out-of-repo fuzzers established here