Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pdfplumber: Integration #12949

Merged
merged 3 commits into from
Jan 27, 2025

Conversation

ennamarie19
Copy link
Contributor

This pull request integrates the Dockerfile needed to build the fuzzers for pdfplumber.

Note: The fuzzers were NOT merged upstream following discussion with the project maintainer here and with the precedence for out-of-repo fuzzers established here

@ennamarie19 ennamarie19 changed the title Integration Pdfplumber: Integration Jan 18, 2025
Copy link

ennamarie19 has previously contributed to projects/pdfplumber. The previous PR was #12567

Copy link
Contributor

@DonggeLiu DonggeLiu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @ennamarie19

@DonggeLiu DonggeLiu merged commit ad1d940 into google:master Jan 27, 2025
15 checks passed
@jsvine
Copy link

jsvine commented Jan 30, 2025

Thank you, @ennamarie19. I'm the maintainer of pdfplumber. I've started receiving results of the fuzzing via email. Some look helpful, while others appeared to be triggered by problems with a core dependency, pdfminer.six. For example, this one: https://oss-fuzz.com/testcase-detail/5914823472250880

Is there a way to set up the fuzzer to ignore errors that originate with that dependency? That would help me focus on issues I can directly fix in pdfplumber.

@ennamarie19
Copy link
Contributor Author

ennamarie19 commented Jan 30, 2025 via email

jsvine added a commit to jsvine/pdfplumber that referenced this pull request Feb 9, 2025
@jsvine
Copy link

jsvine commented Feb 9, 2025

Thanks, @ennamarie19. I've pushed a commit that handles exceptions stemming from pdfminer.six and malformed PDFs: jsvine/pdfplumber@43ccc5b

Would it make sense to have the fuzzer then ignore these particular exceptions?:

from pdfplumber.utils.exceptions import MalformedPDFException, PdfminerException

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants