Fix build with Boost 1.89.0 #3903
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
41 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the upcoming Boost 1.89.0 release, the Boost.System stub library introduced back in 1.691 has been removed (boostorg/system@7a495bb), which causes a CMake error.
The OPTIONAL_COMPONENTS usage is based on upstream recommendation at
https://github.com/boostorg/system/issues/132#issuecomment-3146378680. This has been part of FindBoost since 3.112 so should match minimum CMake.If needed, could check
Boost_SYSTEM_FOUNDandBoost_{MAJOR,MINOR}_VERSIONto continue erroring if Boost.System < 1.69 is not found.Footnotes
https://www.boost.org/doc/libs/1_69_0/libs/system/doc/html/system.html#changes_in_boost_1_69 ↩
https://cmake.org/cmake/help/v3.11/module/FindBoost.html ↩