fix: make IssueKind public and export it in __all__#426
Open
kredd2506 wants to merge 1 commit intogoogle:mainfrom
Open
fix: make IssueKind public and export it in __all__#426kredd2506 wants to merge 1 commit intogoogle:mainfrom
kredd2506 wants to merge 1 commit intogoogle:mainfrom
Conversation
Rename _IssueKind to IssueKind so users can filter individual ValidationIssue objects without importing a private symbol. Fixes google#389
|
Your branch is 1 commits behind git fetch origin main
git merge origin/main
git pushNote: Enable "Allow edits by maintainers" to allow automatic updates. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Rename
_IssueKind→IssueKind(drop the leading underscore) and add it to__all__inprompt_validation.py.ValidationIssue.issue_kindis a public field typed as_IssueKind, a private enum not included in__all__. This forces users to import a private symbol to filter individual issues:Fixes #389
Bug fix
How Has This Been Tested?
Checklist:
pylintover the affected code.