Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add graphs integration tests for pythonboard #193

Merged
merged 1 commit into from
Nov 16, 2023
Merged

Add graphs integration tests for pythonboard #193

merged 1 commit into from
Nov 16, 2023

Conversation

kex103
Copy link
Contributor

@kex103 kex103 commented Nov 16, 2023

Adds integration tests for accumulating-context and math to pythonboard

It's a good idea to open an issue first for discussion.

  • Tests pass
  • Appropriate changes to documentation are included in the PR

@kex103 kex103 requested a review from dglazkov November 16, 2023 00:22
@kex103
Copy link
Contributor Author

kex103 commented Nov 16, 2023

Some work I had done a few weeks before my trip.

This runs integration tests for graphs in python. This change introduces simple ones like accumulating-context and math, but I'd like to add more complex graphs into the suite in follow-up commits.

Copy link
Collaborator

@dglazkov dglazkov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing! LGTM

@kex103 kex103 merged commit 3c0f174 into main Nov 16, 2023
@aomarks aomarks deleted the pythonboard branch December 12, 2023 21:26
@aomarks aomarks restored the pythonboard branch December 12, 2023 21:30
@aomarks aomarks deleted the pythonboard branch December 12, 2023 21:41
Mearman pushed a commit to ExaDev/google-labs-prototypes that referenced this pull request Dec 18, 2023
Mearman pushed a commit to ExaDev/google-labs-prototypes that referenced this pull request Dec 18, 2023
Mearman pushed a commit to ExaDev/google-labs-prototypes that referenced this pull request Dec 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants