Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add application label to the Media UI model #2506

Merged
merged 2 commits into from
Jan 24, 2025
Merged

Add application label to the Media UI model #2506

merged 2 commits into from
Jan 24, 2025

Conversation

AnkitAti
Copy link
Collaborator

WHAT

Add application label to MediaUiModel which can serve as the description for the application icon.

WHY

This change helps setting appropriate content description for the application icon, when used.

Checklist 📋

  • Add explicit visibility modifier and explicit return types for public declarations
  • Run spotless check
  • Run tests
  • Update metalava's signature text files

@AnkitAti AnkitAti requested review from schmiphi and yschimke January 23, 2025 12:33
@AnkitAti AnkitAti merged commit e1f07e4 into google:main Jan 24, 2025
6 checks passed
@AnkitAti AnkitAti deleted the application_label branch January 24, 2025 09:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@schmiphi schmiphi schmiphi approved these changes

@yschimke yschimke yschimke approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@AnkitAti @yschimke @schmiphi