Updates padding for ResponsiveTimeText #2317
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Did we confirm the 4 dp? I had some vague notion 2dp was suggested. |
yschimke
approved these changes
Jul 26, 2024
Will wait for that confirmation before regenerating the screenshots? |
BowerSteve
reviewed
Jul 29, 2024
|
@garanj updated and am running updates here https://github.com/google/horologist/actions/runs/10147468121 |
|
We should change this PR, or recreate off this branch https://github.com/garanj/horologist/commits/time-text-padding/ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WHAT
Updates padding for
ResponsiveTimeTextbased on updated guidance.WHY
Guidance has been updated
HOW
Checklist 📋