Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add further test cases for responsive dialogs #2010

Merged
merged 2 commits into from
Jan 26, 2024
Merged

Add further test cases for responsive dialogs #2010

merged 2 commits into from
Jan 26, 2024

Conversation

BowerSteve
Copy link
Collaborator

Update AlertDialog variations to handle more cases.

WHAT

Added icon to alert content, added screenshot tests, added sample for confirmation dialog

WHY

Coverage of test cases

HOW

Checklist 📋

  • Add explicit visibility modifier and explicit return types for public declarations
  • Run spotless check
  • Run tests
  • Update metalava's signature text files

@yschimke yschimke closed this Jan 26, 2024
@yschimke yschimke reopened this Jan 26, 2024
@yschimke
Copy link
Collaborator

FYI: Closing and reopening triggers the jobs to run after the fixup job.

@yschimke yschimke merged commit a060669 into main Jan 26, 2024
5 checks passed
@yschimke yschimke deleted the DialogUpdates branch January 26, 2024 16:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants