Add test for workdir being a symlink to another folder #11915
+64
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Should only pass after google#11910 is merged in. Thanks @avagin for help here!
|
LGTM. Thanks. |
copybara-service bot
pushed a commit
that referenced
this pull request
Jul 15, 2025
Should only pass after #11910 is merged in. Thanks @avagin for help here! #11910 (comment) FUTURE_COPYBARA_INTEGRATE_REVIEW=#11915 from ekzhang:add-test-symlink-workdir a8cf826 PiperOrigin-RevId: 783271203
copybara-service bot
pushed a commit
that referenced
this pull request
Jul 15, 2025
Should only pass after #11910 is merged in. Thanks @avagin for help here! #11910 (comment) FUTURE_COPYBARA_INTEGRATE_REVIEW=#11915 from ekzhang:add-test-symlink-workdir a8cf826 PiperOrigin-RevId: 783271203
copybara-service bot
pushed a commit
that referenced
this pull request
Jul 15, 2025
Should only pass after #11910 is merged in. Thanks @avagin for help here! #11910 (comment) FUTURE_COPYBARA_INTEGRATE_REVIEW=#11915 from ekzhang:add-test-symlink-workdir a8cf826 PiperOrigin-RevId: 783271203
copybara-service bot
pushed a commit
that referenced
this pull request
Jul 15, 2025
Should only pass after #11910 is merged in. Thanks @avagin for help here! #11910 (comment) FUTURE_COPYBARA_INTEGRATE_REVIEW=#11915 from ekzhang:add-test-symlink-workdir a8cf826 PiperOrigin-RevId: 783271203
copybara-service bot
pushed a commit
that referenced
this pull request
Jul 15, 2025
Should only pass after #11910 is merged in. Thanks @avagin for help here! #11910 (comment) FUTURE_COPYBARA_INTEGRATE_REVIEW=#11915 from ekzhang:add-test-symlink-workdir a8cf826 PiperOrigin-RevId: 783271203
copybara-service bot
pushed a commit
that referenced
this pull request
Jul 15, 2025
Should only pass after #11910 is merged in. Thanks @avagin for help here! #11910 (comment) FUTURE_COPYBARA_INTEGRATE_REVIEW=#11915 from ekzhang:add-test-symlink-workdir a8cf826 PiperOrigin-RevId: 783271203
copybara-service bot
pushed a commit
that referenced
this pull request
Jul 15, 2025
Should only pass after #11910 is merged in. Thanks @avagin for help here! #11910 (comment) FUTURE_COPYBARA_INTEGRATE_REVIEW=#11915 from ekzhang:add-test-symlink-workdir a8cf826 PiperOrigin-RevId: 783271203
|
This test fails on buildkite: |
avagin
reviewed
Jul 16, 2025
|
|
||
| // Additional test: verify we can actually use the working directory | ||
| // by creating a file in it | ||
| _, err = d.Run(ctx, opts, "sh", "-c", "echo 'test content' > testfile && cat testfile") |
There was a problem hiding this comment.
you can combine this command with the previous one to avoid executing the same container twice.
avagin
reviewed
Jul 16, 2025
|
|
||
| // Test that the container can start with symlinked working directory | ||
| // and that pwd returns the symlinked path | ||
| got, err := d.Run(ctx, opts, "sh", "-c", "pwd") |
There was a problem hiding this comment.
In gVisor, pwd returns targetDir, which differs from Linux's behavior. However, this doesn't like a critical issue. You can file a separate issue for that.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should only pass after #11910 is merged in.
Thanks @avagin for help here!
#11910 (comment)