Skip to content

Skip build output directories in testLocationsFrom_idempotentScan. #8312

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Aaron-PintoTamayo wants to merge 1 commit into
base: master
Choose a base branch
from
+10 −0
Open

Skip build output directories in testLocationsFrom_idempotentScan. #8312

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions guava-tests/test/com/google/common/reflect/ClassPathTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -488,6 +488,9 @@ public void testLocationsFrom_idempotentScan() throws IOException {
ClassPath.locationsFrom(getClass().getClassLoader());
assertThat(locations).isNotEmpty();
for (ClassPath.LocationInfo location : locations) {
if (isInBuildOutputDirectory(location.file())) {
continue;
}
ImmutableSet<ResourceInfo> resources = location.scanResources();
assertThat(location.scanResources()).containsExactlyElementsIn(resources);
}
Expand Down Expand Up @@ -622,6 +625,13 @@ private static ImmutableSet<String> scanResourceNames(ClassLoader loader) throws
return builder.build();
}

// Build output directories (e.g., target/, build/) may have files written during test execution.
private static boolean isInBuildOutputDirectory(File file) {
String path = file.getPath();
return path.contains(File.separator + "target" + File.separator)
|| path.contains(File.separator + "build" + File.separator);
}

private static boolean isWindows() {
return OS_NAME.value().startsWith("Windows");
}
Expand Down