Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refresh user profile on ID token change #2132

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

nwkotto
Copy link
Contributor

@nwkotto nwkotto commented Jan 8, 2025

Closes #1109

Previously, we were only updating the user and user profile on sign-in / sign-out. This updates that logic to also make those updates on changes to the ID token.

@nwkotto nwkotto requested review from gino-m and rfontanarosa January 8, 2025 15:40
@auto-assign auto-assign bot requested a review from amysorto January 8, 2025 15:40
Copy link
Collaborator

@gino-m gino-m left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Were you able to verify this works manually?

@nwkotto
Copy link
Contributor Author

nwkotto commented Jan 8, 2025

LGTM. Were you able to verify this works manually?

I wasn't sure how, exactly. Do you know how to reproduce this?

@gino-m
Copy link
Collaborator

gino-m commented Jan 8, 2025

Not sure, you'd probably need to modify the expiration on the cookie, but I suppose you can try hard coding it to emit a refresh to test since the former approach may be hard

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Refresh db on changes to user profile
2 participants