Update URL paths and remove unused code #2118
Conversation
| private static readonly JOB_ID_FRAGMENT_PARAM = 'job'; | ||
| private static readonly LOI_ID_FRAGMENT_PARAM = 'site'; | ||
| private static readonly SUBMISSION_ID_FRAGMENT_PARAM = 'submission'; | ||
| private static readonly TASK_ID_FRAGMENT_PARAM = 'task'; |
There was a problem hiding this comment.
Hi @amysorto ! This will rename the fragments, but we also need the router to use the URI rather than URL fragment. The exact patterns are described in the issue descriptions. Please lmk if you have any questions!
|
@amysorto Gentle ping! |
amysorto
force-pushed
the
url-change
branch
2 times, most recently
from
f1ee798 to
eda4edc
Compare
|
I deleted everything inside |
web/src/app/routing.module.ts
Outdated
| @@ -95,6 +95,21 @@ const routes: Routes = [ | |||
| component: TermsComponent, | |||
| canActivate: [AuthGuard], | |||
| }, | |||
| { | |||
| path: `${NavigationService.SURVEY_SEGMENT}/:${NavigationService.SURVEY_ID}/${NavigationService.LOI_SEGMENT}/:${NavigationService.LOI_ID}`, | |||
There was a problem hiding this comment.
Can we use destructuring assignment to make these constants more readable? ie somewhere above const {SURVEY_SEGMENT, LOI_SEGMENT, ...} = NavigationService;?
| this.setFragmentParams(new HttpParams({fromString: ''})); | ||
| showSubmissionDetail(surveyId: string, loiId: string, submissionId: string) { | ||
| this.router.navigateByUrl( | ||
| `${NavigationService.SURVEY_SEGMENT}/${surveyId}/${NavigationService.LOI_SEGMENT}/${loiId}/${NavigationService.SUBMISSION_SEGMENT}/${submissionId}` |
| @@ -186,7 +180,7 @@ export class NavigationService { | |||
| taskId: string | |||
| ) { | |||
| this.router.navigateByUrl( | |||
| `${NavigationService.SURVEY_SEGMENT}/${surveyId}/${NavigationService.LOI_SEGMENT}/${loiId}/${NavigationService.SUBMISSION_SEGMENT}/${submissionId}/${NavigationService.TASK_SEGMENT}/${taskId}` | |||
| `${SURVEY_SEGMENT}/${surveyId}/${LOI_SEGMENT}/${loiId}/${SUBMISSION_SEGMENT}/${submissionId}/${TASK_SEGMENT}/${taskId}` | |||
There was a problem hiding this comment.
FYI: Using taskId to identify the result will become problematic once we allow repeated tasks. That's out of scope for this PR, just wanted to call it out for future changes.
There was a problem hiding this comment.
That's good to know! Currently the taskId is used just to highlight the task
Fixes #1243
Also removed
LOI_JOB_ID_FRAGMENT_PARAMsince it not currently being used