Make Matcher::ActualT a generic parameter instead of an associated type #349
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bjacotg
force-pushed
the
generic_parameter
branch
3 times, most recently
from
3854a1d to
81abbac
Compare
bjacotg
force-pushed
the
generic_parameter
branch
from
81abbac to
4b67c37
Compare
copybara-service bot
pushed a commit
to protocolbuffers/protobuf
that referenced
this pull request
Feb 16, 2024
-- 4b67c374d49b00860a8f285aae2e064cc58a0dc7 by Bastien Jacot-Guillarmod <[email protected]>: Make `ActualT` in `Matcher` a generic type parameter. COPYBARA_INTEGRATE_REVIEW=google/googletest-rust#349 from google:generic_parameter 4b67c374d49b00860a8f285aae2e064cc58a0dc7 FUTURE_COPYBARA_INTEGRATE_REVIEW=google/googletest-rust#349 from google:generic_parameter 4b67c374d49b00860a8f285aae2e064cc58a0dc7 PiperOrigin-RevId: 607661947
copybara-service bot
pushed a commit
to protocolbuffers/protobuf
that referenced
this pull request
Feb 16, 2024
-- 4b67c374d49b00860a8f285aae2e064cc58a0dc7 by Bastien Jacot-Guillarmod <[email protected]>: Make `ActualT` in `Matcher` a generic type parameter. COPYBARA_INTEGRATE_REVIEW=google/googletest-rust#349 from google:generic_parameter 4b67c374d49b00860a8f285aae2e064cc58a0dc7 FUTURE_COPYBARA_INTEGRATE_REVIEW=google/googletest-rust#349 from google:generic_parameter 4b67c374d49b00860a8f285aae2e064cc58a0dc7 PiperOrigin-RevId: 607661947
bjacotg
changed the title
This was referenced May 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change will fix #323.
Matchers will be more generic so they will be able to handle different
ActualTtypes, which is most necessary for types with parametric lifetime. However, this will bring back the issues withMatcher::andandMatcher::orbeing non-deterministic. This is solved by moving these functions to a non-generic extension trait.