fix(ping): fix auto detect service scheme issue #2166
+36
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Subserial
requested changes
Nov 21, 2025
Contributor
Subserial
left a comment
Subserial
left a comment
There was a problem hiding this comment.
Please add a test for this case.
Contributor
Author
tests added |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add auto registry scheme(https/http) detect for Ping().
If registry auto redirect http to https( or https to http), and we try to use name.Insecure option, Ping() func has chances stopped by http.Client for too many redirects. And the fixture just replace original scheme with successful request's scheme