Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[nnx] fix MultiMetric typing #4485

Merged
merged 1 commit into from
Jan 16, 2025
Merged

[nnx] fix MultiMetric typing #4485

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion flax/nnx/training/metrics.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -373,7 +373,7 @@ def update(self, **updates) -> None:
for metric_name in self._metric_names:
getattr(self, metric_name).update(**updates)

def compute(self) -> dict[str, Metric]:
def compute(self) -> dict[str, tp.Any]:
"""Compute and return the value of all underlying ``Metric``'s. This method
will return a dictionary, mapping strings (defined by the key-word arguments
``**metrics`` passed to the constructor) to the corresponding metric value.
Expand Down
Loading