Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add dataset loading guide (Issue #2116) #3450

Merged
merged 1 commit into from
Nov 15, 2023

Conversation

VictorPrins
Copy link
Contributor

This pull request ticks off the third requested guide from #2116.
It contains a new guide on loading datasets, using the example of MNIST and the APIs from Torchvision, Tensorflow, and Hugging Face.

@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@VictorPrins
Copy link
Contributor Author

@chiamp @cgarciae Just drawing some attention since I'm a new contributor. Thanks!

@chiamp
Copy link
Collaborator

chiamp commented Nov 13, 2023

Sorry for the delay, thanks for adding this @VictorPrins! Can you rebase your branch so that it's up-to-date with main and then move the guide under data_preprocessing?

@VictorPrins VictorPrins reopened this Nov 13, 2023
@VictorPrins
Copy link
Contributor Author

@chiamp thanks for your reply! I'd be excited to contribute more to the project. This PR should be ready to merge now, if you have no further comments on the changes.

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (2f6e5ff) 52.10% compared to head (ab95331) 52.10%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3450   +/-   ##
=======================================
  Coverage   52.10%   52.10%           
=======================================
  Files          91       91           
  Lines       10968    10968           
=======================================
  Hits         5715     5715           
  Misses       5253     5253           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@copybara-service copybara-service bot merged commit 091df13 into google:main Nov 15, 2023
33 checks passed
@chiamp
Copy link
Collaborator

chiamp commented Nov 15, 2023

Merged now, thanks!

@VictorPrins VictorPrins deleted the loading-data-guide branch November 15, 2023 10:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants