Skip to content

Comments

[Java] Improve java API#8914

Open
satur9nine wants to merge 2 commits intogoogle:masterfrom
satur9nine:improve-java-iface
Open

[Java] Improve java API#8914
satur9nine wants to merge 2 commits intogoogle:masterfrom
satur9nine:improve-java-iface

Conversation

@satur9nine
Copy link
Contributor

  • Makes Java API for vectors cleaner like Rust, Swift and Python
  • Don't silently drop arrays of incorrect fixed length, throw instead
  • Restore missing JavaTest.sh
  • Ensure all vector creation examples in tutorial mention reverse order
  • Fix Kotlin shell script to ensure bash is used

- Makes Java API for vectors cleaner like Rust, Swift and Python
- Don't silently drop arrays of incorrect fixed length, throw instead
- Restore missing JavaTest.sh
- Ensure all vector creation examples in tutorial mention reverse order
- Fix Kotlin shell script to ensure bash is used
@github-actions github-actions bot added java c++ codegen Involving generating code from schema documentation Documentation labels Jan 25, 2026
@jtdavis777
Copy link
Collaborator

hey @satur9nine - any concerns that a change like this will break existing code?

@satur9nine
Copy link
Contributor Author

hey @satur9nine - any concerns that a change like this will break existing code?

Overall test coverage is very good so I don't see any big risks but there is one notable behavior change. I fixed a bug I mentioned in the commit message "Don't silently drop arrays of incorrect fixed length, throw instead". Notice IllegalArgumentException is now thrown if the user passes an array of the wrong size rather than the incorrectly sized array being dropped. It's possible that some subset of users are adding arrays that are getting dropped and they simple never cared about that data being dropped, anything is possible but its easily fixed on their end and they probably would want to know about silent data loss, but of course some users could consider fixing a bug as a "break".

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

c++ codegen Involving generating code from schema documentation Documentation java

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants