Additional load time optimization #165
Merged
+177
−101
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shanminchao
force-pushed
the
optimization
branch
from
ae2b00e to
03323e8
Compare
That is great! :D |
shanminchao
force-pushed
the
optimization
branch
2 times, most recently
from
7134c23 to
6cfcb29
Compare
added 3 commits
January 28, 2025 10:31
Probably only improves performance by a tiny bit
shanminchao
force-pushed
the
optimization
branch
from
6cfcb29 to
2987239
Compare
wangra-google
approved these changes
Jan 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The big wins here are from converting many of the critical path functions from using maps to DiveVectors in pm4_info.cpp.
Additionally, some additional pre-reservations are made in commandhierarchy.
On my Windows machine, for a particularly heavy capture, the RELEASE load time decreased by about 3-7 seconds, from about 56s total to about 50s. (There's a lot of variance in profiling in Windows). DEBUG load time is currently at about ~330s, about a 40s improvement from the previous 370s.
On my beefier work Linux machine, load times in RELEASE went down from 23s to about 21.5s.