Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes for building gfxr on Windows targeting Android #159

Merged
merged 1 commit into from
Jan 13, 2025

Conversation

angela28chen
Copy link
Collaborator

Some changes to get Dive Android libraries building on Windows after the GFXR addition.

  • Triggering gfxr gradle builds and extracting/copying files is now only done inside CMakeLists.txt for the Linux host build, this has been implemented in scripts/build_android.bat for Windows.
  • The gfxr builds for different versions (Debug/Release) are separated so that it's easier to only build one by modifying BUILD_TYPE in scripts/build_android.bat
  • Different from the Linux host build, the replay folder is copied to build_android/Debug/third_party/gfxreconstruct/android/tools/replay/ rather than build_android/Debug/third_party/gfxreconstruct/android/tools/replay/build/outputs/apk/debug
  • Updated documentation

@RenfengLiu
Copy link
Collaborator

Curious will there's be another PR for Linux so that the two platform behave the same?

@angela28chen
Copy link
Collaborator Author

I agree it's better to be consistent between the two platforms, but I tried again and I am still unable to get the cmake calling gradle to function properly on Windows so I think modifying the batch file is still needed. I plan to make a followup CL for Linux with the following:

  1. Disentangle Debug/Release builds
  2. Change replay folder location to match the one specified in this PR on Windows

I verified that on Linux, triggering the gradle build from within cmake file works well. I'm not sure it's worth the effort to change that to the sh file just for consistency, but I could look into that if it's desirable. That will be remaining difference.

@angela28chen angela28chen merged commit 696d6f4 into google:main Jan 13, 2025
7 checks passed
@angela28chen angela28chen deleted the windows-build branch January 15, 2025 17:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants