Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Caliper on Java 6 VM and ClassNotFound when using class defined on classpath. #317

Open
wants to merge 7 commits into
base: master
Choose a base branch
from

Conversation

phishman3579
Copy link

Fixed a number of issues when using Caliper with a Java 6 VM (1.6.0_65):

  • ServerSocketServiceTest was using a java 7 only getLoopbackAddress() method
  • AllocationRecorder and AllocationInstrumentTest used values which weren't compatible

Fixed ClassNotFound exception when trying to load a class which was defined in a jar on the classpath (this is a java 6 & 7 problem, I believe):

  • WorkerMain
  • ExperimentModule
  • CaliperConfig

@cgdecker cgdecker added P4 type=defect Bug, not working as expected labels Oct 2, 2019
try {
urls = new URL[] { ROOT.toURI().toURL() };
} catch (MalformedURLException e) {
System.err.println("Could get root URI, class lookup via Util.lookupClass() will not work. root="+ROOT);

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we really need to log with System.io?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P4 type=defect Bug, not working as expected
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants