Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the inplace sign operation #1202

Merged
merged 1 commit into from
Nov 22, 2023
Merged

Fix the inplace sign operation #1202

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 1 addition & 4 deletions lion/lion_pytorch.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,10 +78,7 @@ def step(self, closure=None):
# Weight update
update = exp_avg * beta1 + grad * (1 - beta1)

p.add_(torch.sign(update), alpha=-group['lr'], inplace=True)
#This has been made more efficient by using the torch.sign function's inplace mode.
#This will prevent the need to create a new tensor for the updated parameter,
#which can save a significant amount of time for large models.
p.add_(update.sign_(), alpha=-group['lr'])

# Decay the momentum running average coefficient
exp_avg.mul_(beta2).add_(grad, alpha=1 - beta2)
Expand Down