-
Notifications
You must be signed in to change notification settings - Fork 310
Adds Benchmark module to evaluate the SDK's first run performance #1489
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Generalization of FhirEngineRetrieveProvider
# Conflicts: # build.gradle.kts # buildSrc/src/main/kotlin/Plugins.kt # settings.gradle.kts # workflow/src/androidTest/java/com/google/android/fhir/workflow/FhirOperatorLibraryEvaluateTest.kt # workflow/src/main/java/com/google/android/fhir/workflow/FhirEngineRetrieveProvider.kt # workflow/src/main/java/com/google/android/fhir/workflow/FhirOperator.kt
jingtang10
requested changes
Nov 22, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can you add to the description how to run the benchmarking?
benchmark/src/androidTest/java/com/google/android/fhir/benchmark/G_CqlEvaluatorBenchmark.kt
Outdated
Show resolved
Hide resolved
benchmark/src/androidTest/java/com/google/android/fhir/benchmark/G_CqlEvaluatorBenchmark.kt
Outdated
Show resolved
Hide resolved
jingtang10
approved these changes
Dec 2, 2022
This was referenced Dec 2, 2022
Closed
Closed
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1474, #825 and #1378, potential merger with #1414
Description
Adds a simple benchmark module to run performance tests on the engine and workflow. The module is focused on the first-time runs, which drive most of the performance issues we are having. The tests must be run in order.
I am not convinced that yet another module needs to be added, but given our struggles with performance, it might be a good short-term investment.
Current results in nanoseconds (seconds,milli,micro,nano) on an older Moto Z Play XT1635-02: (Android8, 3GB RAM, Octa-core 2.0 GHz) with Geekbench: 147 single core and 544 multi-core. These are single runs, but first-time runs (no caching):
Pixel 6 GB7N6 (Android 12, 8GB RAM, Octa-core (2x2.80 GHz Cortex-X1 & 2x2.25 GHz Cortex-A76 & 4x1.80 GHz Cortex-A55) with Geekbench: 1036 single core and 2720 multi-core:
Alternative(s) considered
I tried building an app and a macro module, but I think this micromodule is a better approach.
Type
Testing
Screenshots (if applicable)
Checklist
./gradlew spotlessApply
and./gradlew spotlessCheck
to check my code follows the style guide of this project../gradlew check
and./gradlew connectedCheck
to test my changes locally.