Image buffers #757
Merged
Image buffers #757
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dj2
reviewed
Dec 16, 2019
| @@ -137,18 +137,38 @@ END | |||
| BUFFER {name} DATA_TYPE {type} {STD140 | STD430} SIZE _size_in_items_ \ | |||
| {initializer} | |||
|
|
|||
| # Defines a buffer with width and height and filled by data as specified by the | |||
There was a problem hiding this comment.
Thinking about this, I think we should leave this here and just add a # Deprecated use IMAGE tag
docs/amber_script.md
Outdated
|
|
||
| ```groovy | ||
| # Specify an image buffer with a format. HEIGHT is necessary for DIM_2D and | ||
| DIM_3D. DEPTH is necessary for DIM_3D. |
docs/amber_script.md
Outdated
| {initializer} | ||
|
|
||
| # Specify an image buffer with a data type. HEIGHT is necessary for DIM_2D and | ||
| DIM_3D. DEPTH is necessary for DIM_3D. |
|
|
||
| # Specify an image buffer with a data type. HEIGHT is necessary for DIM_2D and | ||
| DIM_3D. DEPTH is necessary for DIM_3D. | ||
| IMAGE {name} DATA_TYPE {type} {dimensionality} \ |
src/amberscript/parser.cc
Outdated
| if (!token->IsString()) | ||
| return Result("invalid IMAGE command provided"); | ||
|
|
||
| std::unique_ptr<Buffer> buffer; |
There was a problem hiding this comment.
Could probably just do:
auto buffer = MakeUnique<Buffer>();
we'd waste the allocation in case of error, but otherwise we always make the buffer this way.
src/amberscript/parser.cc
Outdated
|
|
||
| fmt = MakeUnique<Format>(new_type.get()); | ||
| buffer->SetFormat(fmt.get()); | ||
| type = new_type.get(); |
src/amberscript/parser.cc
Outdated
| } else { | ||
| return Result("unknown IMAGE command provided: " + cmd); | ||
| } | ||
| buffer->SetName(name); |
There was a problem hiding this comment.
This could then move up with the buffer creation
dj2
approved these changes
Dec 16, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contributes to #747
Add support for specifying buffers as images via a new command.
Generalize image support to support 1D and 3D images.
Add some examples of the new functionality.