-
Notifications
You must be signed in to change notification settings - Fork 2.8k
fix(models): handle mixed tool responses and text/media in LiteLLM ad… #4109
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Changes from 4 commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
36dfe40
fix(models): handle mixed tool responses and text/media in LiteLLM ad…
Akshat8510 1b93ecb
fix: refactor content conversion to support multipart and mixed tool …
Akshat8510 01c3773
docs: improve docstring and remove dead code as per AI review
Akshat8510 4768ddf
docs: improve docstring and remove dead code as per AI review
Akshat8510 fcd150d
Merge branch 'main' into fix-litellm-multipart
Akshat8510 827487d
docs: improve docstring and remove dead code as per AI review
Akshat8510 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
After this return statement, there is a block of unreachable code from line 551 to 608. This seems to be leftover code from the refactoring that should be removed to improve code clarity and maintainability.