Skip to content

fix: creates an InMemoryMemoryService within the EvaluationGenerator #2263

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 3 commits into from
Closed

fix: creates an InMemoryMemoryService within the EvaluationGenerator #2263

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
7f6271e
create an InMemoryMemoryService within the evaluation generator and p…
sjhatfield Jul 30, 2025
8953a9c
Merge branch 'main' into main
DeanChensj Aug 7, 2025
8d6fca4
Update evaluation_generator.py
DeanChensj Aug 7, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions src/google/adk/evaluation/evaluation_generator.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,8 @@
from ..agents.llm_agent import Agent
from ..artifacts.base_artifact_service import BaseArtifactService
from ..artifacts.in_memory_artifact_service import InMemoryArtifactService
from ..memory.base_memory_service import BaseMemoryService
from ..memory.in_memory_memory_service import InMemoryMemoryService
from ..runners import Runner
from ..sessions.base_session_service import BaseSessionService
from ..sessions.in_memory_session_service import InMemorySessionService
Expand Down Expand Up @@ -142,11 +144,15 @@ async def _generate_inferences_from_root_agent(
session_id: Optional[str] = None,
session_service: Optional[BaseSessionService] = None,
artifact_service: Optional[BaseArtifactService] = None,
memory_service: Optional[BaseMemoryService] = None,
) -> list[Invocation]:
"""Scrapes the root agent given the list of Invocations."""
if not session_service:
session_service = InMemorySessionService()

if not memory_service:
memory_service = InMemoryMemoryService()

app_name = (
initial_session.app_name if initial_session else "EvaluationGenerator"
)
Expand All @@ -168,6 +174,7 @@ async def _generate_inferences_from_root_agent(
agent=root_agent,
artifact_service=artifact_service,
session_service=session_service,
memory_service=memory_service,
)

# Reset agent state for each query
Expand Down